About [tags] in issue and PR headers

[Roman Leventov <le...@apache.org>]

1) Do other people want proposal issues to have [PROPOSAL] in their names,
despite they also have a corresponding tag? Maybe we can at least make it
not caps?

2) Would be nice to teach bot to visit PRs and issues from non-committers
and remove "[tag name]" parts from their titles and assign corresponding
tags.

Re: About [tags] in issue and PR headers

[Gian Merlino <gi...@gmail.com>]

I’d also be ok with ditching them all except “Backport”.

Gian

> On Mar 15, 2019, at 15:36, Jonathan Wei <jo...@apache.org> wrote:
> 
> I don't mind the [TAG] in the titles, but I think github labels are better,
> and I'm fine with removing the [TAG]s.
> 
> [Backport] would be the only tag I feel we should keep, just to
> disambiguate between the backport and the original PR.
> 
>> On Fri, Mar 15, 2019 at 11:26 AM Gian Merlino <gi...@apache.org> wrote:
>> 
>> I do think that other than a couple key ones like proposal and backport, we
>> should encourage people to not put tags (or issue #s) in PR titles.
>> 
>>> On Thu, Mar 14, 2019 at 7:56 PM Gian Merlino <gi...@apache.org> wrote:
>>> 
>>> Personally I use email as my main interface to see what's new in github,
>>> and it doesn't show labels, and I think being able to pick out proposals
>>> and backports easily is useful. So I like the tags. But, not so much
>> that I
>>> would fight to keep them if consensus is going the other direction.
>>> 
>>> On Thu, Mar 14, 2019 at 2:59 PM Clint Wylie <cl...@imply.io>
>> wrote:
>>> 
>>>> I find [PROPOSAL] and all other title tags redundant and prefer the
>> github
>>>> labels since they are easier to use for searching, and would prefer the
>>>> tags in the title were not there. I guess I don't mind [Backport] as
>> much
>>>> because it makes it really stand out that it's a PR for backporting for
>>>> release, but it is also probably not necessary if we just want to get
>> rid
>>>> of them entirely. I feel the same about putting the issue number in the
>> PR
>>>> title, which is also pretty worthless since it doesn't link it.
>>>> 
>>>> A bot to automatically do that might be nice, +1. I wonder how much work
>>>> it
>>>> would be to examine which paths are modified by a PR to attempt to
>>>> automatically add 'Area' labels too, but that might be overkill.
>>>> 
>>>> On Thu, Mar 14, 2019 at 2:36 PM Roman Leventov <le...@apache.org>
>>>> wrote:
>>>> 
>>>>> 1) Do other people want proposal issues to have [PROPOSAL] in their
>>>> names,
>>>>> despite they also have a corresponding tag? Maybe we can at least make
>>>> it
>>>>> not caps?
>>>>> 
>>>>> 2) Would be nice to teach bot to visit PRs and issues from
>>>> non-committers
>>>>> and remove "[tag name]" parts from their titles and assign
>> corresponding
>>>>> tags.
>>>>> 
>>>> 
>>> 
>> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org

Re: About [tags] in issue and PR headers

[Jonathan Wei <jo...@apache.org>]

I don't mind the [TAG] in the titles, but I think github labels are better,
and I'm fine with removing the [TAG]s.

[Backport] would be the only tag I feel we should keep, just to
disambiguate between the backport and the original PR.

On Fri, Mar 15, 2019 at 11:26 AM Gian Merlino <gi...@apache.org> wrote:

> I do think that other than a couple key ones like proposal and backport, we
> should encourage people to not put tags (or issue #s) in PR titles.
>
> On Thu, Mar 14, 2019 at 7:56 PM Gian Merlino <gi...@apache.org> wrote:
>
> > Personally I use email as my main interface to see what's new in github,
> > and it doesn't show labels, and I think being able to pick out proposals
> > and backports easily is useful. So I like the tags. But, not so much
> that I
> > would fight to keep them if consensus is going the other direction.
> >
> > On Thu, Mar 14, 2019 at 2:59 PM Clint Wylie <cl...@imply.io>
> wrote:
> >
> >> I find [PROPOSAL] and all other title tags redundant and prefer the
> github
> >> labels since they are easier to use for searching, and would prefer the
> >> tags in the title were not there. I guess I don't mind [Backport] as
> much
> >> because it makes it really stand out that it's a PR for backporting for
> >> release, but it is also probably not necessary if we just want to get
> rid
> >> of them entirely. I feel the same about putting the issue number in the
> PR
> >> title, which is also pretty worthless since it doesn't link it.
> >>
> >> A bot to automatically do that might be nice, +1. I wonder how much work
> >> it
> >> would be to examine which paths are modified by a PR to attempt to
> >> automatically add 'Area' labels too, but that might be overkill.
> >>
> >> On Thu, Mar 14, 2019 at 2:36 PM Roman Leventov <le...@apache.org>
> >> wrote:
> >>
> >> > 1) Do other people want proposal issues to have [PROPOSAL] in their
> >> names,
> >> > despite they also have a corresponding tag? Maybe we can at least make
> >> it
> >> > not caps?
> >> >
> >> > 2) Would be nice to teach bot to visit PRs and issues from
> >> non-committers
> >> > and remove "[tag name]" parts from their titles and assign
> corresponding
> >> > tags.
> >> >
> >>
> >
>

Re: About [tags] in issue and PR headers

[Gian Merlino <gi...@apache.org>]

I do think that other than a couple key ones like proposal and backport, we
should encourage people to not put tags (or issue #s) in PR titles.

On Thu, Mar 14, 2019 at 7:56 PM Gian Merlino <gi...@apache.org> wrote:

> Personally I use email as my main interface to see what's new in github,
> and it doesn't show labels, and I think being able to pick out proposals
> and backports easily is useful. So I like the tags. But, not so much that I
> would fight to keep them if consensus is going the other direction.
>
> On Thu, Mar 14, 2019 at 2:59 PM Clint Wylie <cl...@imply.io> wrote:
>
>> I find [PROPOSAL] and all other title tags redundant and prefer the github
>> labels since they are easier to use for searching, and would prefer the
>> tags in the title were not there. I guess I don't mind [Backport] as much
>> because it makes it really stand out that it's a PR for backporting for
>> release, but it is also probably not necessary if we just want to get rid
>> of them entirely. I feel the same about putting the issue number in the PR
>> title, which is also pretty worthless since it doesn't link it.
>>
>> A bot to automatically do that might be nice, +1. I wonder how much work
>> it
>> would be to examine which paths are modified by a PR to attempt to
>> automatically add 'Area' labels too, but that might be overkill.
>>
>> On Thu, Mar 14, 2019 at 2:36 PM Roman Leventov <le...@apache.org>
>> wrote:
>>
>> > 1) Do other people want proposal issues to have [PROPOSAL] in their
>> names,
>> > despite they also have a corresponding tag? Maybe we can at least make
>> it
>> > not caps?
>> >
>> > 2) Would be nice to teach bot to visit PRs and issues from
>> non-committers
>> > and remove "[tag name]" parts from their titles and assign corresponding
>> > tags.
>> >
>>
>

Re: About [tags] in issue and PR headers

[Gian Merlino <gi...@apache.org>]

Personally I use email as my main interface to see what's new in github,
and it doesn't show labels, and I think being able to pick out proposals
and backports easily is useful. So I like the tags. But, not so much that I
would fight to keep them if consensus is going the other direction.

On Thu, Mar 14, 2019 at 2:59 PM Clint Wylie <cl...@imply.io> wrote:

> I find [PROPOSAL] and all other title tags redundant and prefer the github
> labels since they are easier to use for searching, and would prefer the
> tags in the title were not there. I guess I don't mind [Backport] as much
> because it makes it really stand out that it's a PR for backporting for
> release, but it is also probably not necessary if we just want to get rid
> of them entirely. I feel the same about putting the issue number in the PR
> title, which is also pretty worthless since it doesn't link it.
>
> A bot to automatically do that might be nice, +1. I wonder how much work it
> would be to examine which paths are modified by a PR to attempt to
> automatically add 'Area' labels too, but that might be overkill.
>
> On Thu, Mar 14, 2019 at 2:36 PM Roman Leventov <le...@apache.org>
> wrote:
>
> > 1) Do other people want proposal issues to have [PROPOSAL] in their
> names,
> > despite they also have a corresponding tag? Maybe we can at least make it
> > not caps?
> >
> > 2) Would be nice to teach bot to visit PRs and issues from non-committers
> > and remove "[tag name]" parts from their titles and assign corresponding
> > tags.
> >
>

Re: About [tags] in issue and PR headers

[Clint Wylie <cl...@imply.io>]

I find [PROPOSAL] and all other title tags redundant and prefer the github
labels since they are easier to use for searching, and would prefer the
tags in the title were not there. I guess I don't mind [Backport] as much
because it makes it really stand out that it's a PR for backporting for
release, but it is also probably not necessary if we just want to get rid
of them entirely. I feel the same about putting the issue number in the PR
title, which is also pretty worthless since it doesn't link it.

A bot to automatically do that might be nice, +1. I wonder how much work it
would be to examine which paths are modified by a PR to attempt to
automatically add 'Area' labels too, but that might be overkill.

On Thu, Mar 14, 2019 at 2:36 PM Roman Leventov <le...@apache.org> wrote:

> 1) Do other people want proposal issues to have [PROPOSAL] in their names,
> despite they also have a corresponding tag? Maybe we can at least make it
> not caps?
>
> 2) Would be nice to teach bot to visit PRs and issues from non-committers
> and remove "[tag name]" parts from their titles and assign corresponding
> tags.
>