[GitHub] [incubator-datalab] ofuks commented on a change in pull request #964: [DLAB-2116] Oduhu unitests

[GitBox <gi...@apache.org>]

ofuks commented on a change in pull request #964:
URL: https://github.com/apache/incubator-datalab/pull/964#discussion_r514097713



##########
File path: services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/OdahuServiceImpl.java
##########
@@ -84,14 +84,15 @@ public OdahuServiceImpl(ProjectService projectService, EndpointService endpointS
         return odahuDAO.findOdahuClusters();
     }
 
-    @Override
+    @Override//TODO:method should be refactored

Review comment:
       Resolve this TODO

##########
File path: services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/OdahuServiceImpl.java
##########
@@ -116,6 +116,8 @@ public void create(@Project String project, OdahuCreateDTO odahuCreateDTO, UserI
                 odahuDAO.updateStatus(odahuCreateDTO.getName(), odahuCreateDTO.getProject(), odahuCreateDTO.getEndpoint(),
                         UserInstanceStatus.FAILED);
             }
+        } else {
+            throw new DlabException("The odahu project " + project + " can not be created.");

Review comment:
       Describe a detailed reason 

##########
File path: services/self-service/src/test/java/com/epam/dlab/backendapi/service/impl/OdahuServiceImplTest.java
##########
@@ -0,0 +1,125 @@
+package com.epam.dlab.backendapi.service.impl;
+
+import com.epam.dlab.auth.UserInfo;
+import com.epam.dlab.backendapi.dao.OdahuDAO;
+import com.epam.dlab.backendapi.domain.EndpointDTO;
+import com.epam.dlab.backendapi.domain.OdahuCreateDTO;
+import com.epam.dlab.backendapi.domain.OdahuDTO;
+import com.epam.dlab.backendapi.domain.ProjectDTO;
+import com.epam.dlab.backendapi.domain.ProjectEndpointDTO;
+import com.epam.dlab.backendapi.domain.RequestId;
+import com.epam.dlab.backendapi.service.EndpointService;
+import com.epam.dlab.backendapi.service.ProjectService;
+import com.epam.dlab.backendapi.util.RequestBuilder;
+import com.epam.dlab.cloud.CloudProvider;
+import com.epam.dlab.dto.UserInstanceStatus;
+import com.epam.dlab.dto.base.edge.EdgeInfo;
+import com.epam.dlab.exceptions.ResourceConflictException;
+import com.epam.dlab.rest.client.RESTService;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import java.util.*;
+
+import static java.util.Collections.singletonList;
+import static org.junit.Assert.assertNotNull;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.when;
+
+@RunWith(MockitoJUnitRunner.class)
+public class OdahuServiceImplTest {
+
+    private static final String USER = "testUser";
+    private static final String TOKEN = "testToken";
+    private static final String PROJECT = "testProject";
+    private static final String END_POINT_URL = "https://localhsot:8080";
+    private static final String END_POINT_NAME = "endpoint";
+    private static final String tag = "testTag";
+    private static final String uuid = "34dsr324";
+    private static final String ODAHU_NAME = "odahuTest";
+
+    private UserInfo userInfo;
+
+    @Mock
+    private OdahuDAO odahuDAO;
+
+    @Mock
+    private ProjectService projectService;
+
+    @Mock
+    private EndpointService endpointService;
+
+    @Mock
+    private RequestId requestId;
+
+    @Mock
+    private RESTService provisioningService;
+
+    @Mock
+    private RequestBuilder requestBuilder;
+
+    @Mock
+    private OdahuServiceImpl odahuService;
+
+    @Before

Review comment:
       Can we use **@BeforeClass** here?

##########
File path: services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/OdahuServiceImpl.java
##########
@@ -84,14 +84,15 @@ public OdahuServiceImpl(ProjectService projectService, EndpointService endpointS
         return odahuDAO.findOdahuClusters();
     }
 
-    @Override
+    @Override//TODO:method should be refactored
     public Optional<OdahuDTO> get(String project, String endpoint) {
         return odahuDAO.getByProjectEndpoint(project, endpoint);
     }
 
     @BudgetLimited
     @Override
     public void create(@Project String project, OdahuCreateDTO odahuCreateDTO, UserInfo user) {
+

Review comment:
       Please remove this line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datalab.apache.org
For additional commands, e-mail: dev-help@datalab.apache.org