You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Alex Karasulu (JIRA)" <ji...@apache.org> on 2007/08/16 18:35:38 UTC

[jira] Created: (DIRSERVER-1020) FilterParser can become inconsistent under certain circumstances: needs rewrite

FilterParser can become inconsistent under certain circumstances: needs rewrite
-------------------------------------------------------------------------------

                 Key: DIRSERVER-1020
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1020
             Project: Directory ApacheDS
          Issue Type: Bug
            Reporter: Alex Karasulu
            Assignee: Stefan Seelmann


I had trouble reproducing this bug in it's entirity but I think a serious rewrite by a antlr pro like seelmann is needed.  If seelmann could make this parser as healthy as the others he has written I think we can get rid of this issue which results from a poorly written antlr parser implementation for filter expression parsing.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-1020) FilterParser can become inconsistent under certain circumstances: needs rewrite

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529858 ] 

Emmanuel Lecharny commented on DIRSERVER-1020:
----------------------------------------------

I have found a way to reproduce this problem. As I was trying to create some new Search test which was using an open server for the whole tests, the filter parser is never reinitialized. I found a failing tests where we send this filter (cn=*o* *o*) which translated to (cn=*o*o*) while it should be (*o**o*) (because of the internal space).

I will see how to fix the parser.

> FilterParser can become inconsistent under certain circumstances: needs rewrite
> -------------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1020
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1020
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Alex Karasulu
>            Assignee: Stefan Seelmann
>             Fix For: 1.5.2
>
>
> I had trouble reproducing this bug in it's entirity but I think a serious rewrite by a antlr pro like seelmann is needed.  If seelmann could make this parser as healthy as the others he has written I think we can get rid of this issue which results from a poorly written antlr parser implementation for filter expression parsing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRSERVER-1020) FilterParser can become inconsistent under certain circumstances: needs rewrite

Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Karasulu closed DIRSERVER-1020.
------------------------------------


> FilterParser can become inconsistent under certain circumstances: needs rewrite
> -------------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1020
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1020
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Alex Karasulu
>            Assignee: Stefan Seelmann
>             Fix For: 1.5.2
>
>
> I had trouble reproducing this bug in it's entirity but I think a serious rewrite by a antlr pro like seelmann is needed.  If seelmann could make this parser as healthy as the others he has written I think we can get rid of this issue which results from a poorly written antlr parser implementation for filter expression parsing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-1020) FilterParser can become inconsistent under certain circumstances: needs rewrite

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-1020:
-----------------------------------------

    Affects Version/s: 1.5.0
        Fix Version/s: 1.5.2

(Adding some version to this issue)

If this issue is considered as a duplicate, can we then close it and mark it as duplicated ?

> FilterParser can become inconsistent under certain circumstances: needs rewrite
> -------------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1020
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1020
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Alex Karasulu
>            Assignee: Stefan Seelmann
>             Fix For: 1.5.2
>
>
> I had trouble reproducing this bug in it's entirity but I think a serious rewrite by a antlr pro like seelmann is needed.  If seelmann could make this parser as healthy as the others he has written I think we can get rid of this issue which results from a poorly written antlr parser implementation for filter expression parsing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRSERVER-1020) FilterParser can become inconsistent under certain circumstances: needs rewrite

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRSERVER-1020.
------------------------------------------

    Resolution: Fixed

Fixed : 
http://svn.apache.org/viewvc?rev=580524&view=rev
http://svn.apache.org/viewvc?rev=580525&view=rev
http://svn.apache.org/viewvc?rev=580526&view=rev

It was not so easy, as the pb was not only in the way we were handling filters, but we had some big bugs with Binary attributes too.

> FilterParser can become inconsistent under certain circumstances: needs rewrite
> -------------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1020
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1020
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Alex Karasulu
>            Assignee: Stefan Seelmann
>             Fix For: 1.5.2
>
>
> I had trouble reproducing this bug in it's entirity but I think a serious rewrite by a antlr pro like seelmann is needed.  If seelmann could make this parser as healthy as the others he has written I think we can get rid of this issue which results from a poorly written antlr parser implementation for filter expression parsing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-1020) FilterParser can become inconsistent under certain circumstances: needs rewrite

Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seelmann updated DIRSERVER-1020:
---------------------------------------

    Assignee: Emmanuel Lecharny  (was: Stefan Seelmann)

Emmanuel did the job.

> FilterParser can become inconsistent under certain circumstances: needs rewrite
> -------------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1020
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1020
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Alex Karasulu
>            Assignee: Emmanuel Lecharny
>             Fix For: 1.5.2
>
>
> I had trouble reproducing this bug in it's entirity but I think a serious rewrite by a antlr pro like seelmann is needed.  If seelmann could make this parser as healthy as the others he has written I think we can get rid of this issue which results from a poorly written antlr parser implementation for filter expression parsing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.