[GitHub] rawlinp commented on a change in pull request #2806: Add sub to validate user input when running postinstall script

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #2806: Add sub to validate user input when running postinstall script
URL: https://github.com/apache/trafficcontrol/pull/2806#discussion_r219559608
 
 

 ##########
 File path: traffic_ops/install/bin/_postinstall
 ##########
 @@ -569,7 +569,7 @@ sub getDefaults {
                 "config_var"      => "tm.url"
             },
             {
-                "Human-readable CDN Name.  (No whitespace, please)" => "kabletown_cdn",
+                "Human-readable CDN Name.  (No whitespace, please)" => "kabletownCdn",
 
 Review comment:
   So my only worry about this is that if underscores really only break DNS-related fields, shouldn't we just target those fields more specifically and make sure they're valid? `cdn_name` should be ok to have underscores in it I'd think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services