You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Arunodoy18 (via GitHub)" <gi...@apache.org> on 2026/02/14 10:39:51 UTC

[PR] fix(athena): pass schema to connect_args for PyAthena metadata discovery [superset]

Arunodoy18 opened a new pull request, #37974:
URL: https://github.com/apache/superset/pull/37974

   Fixes issues where Athena connections would validate successfully but fail during database creation or dataset discovery, especially when using IAM role authentication or working with multiple schemas.
   
   This ensures schema context and authentication details are consistently applied during connection setup and metadata discovery. The change is minimal and preserves existing authentication and connection behavior.
   
   TESTING INSTRUCTIONS
   
   Tested Athena connection using IAM role authentication
   
   Verified database creation works after connection test
   
   Verified correct schema is used during table/dataset discovery
   
   Confirmed no regression for key/secret based auth
   
   ADDITIONAL INFORMATION
   
    Has associated issue: Fixes #17182
   
    Changes UI
   
    Includes DB Migration
   
    Introduces new feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(athena): pass schema to connect_args for PyAthena metadata discovery [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37974:
URL: https://github.com/apache/superset/pull/37974#issuecomment-3901664727

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(athena): pass schema to connect_args for PyAthena metadata discovery [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #37974:
URL: https://github.com/apache/superset/pull/37974#issuecomment-3901677303

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/37974?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.87%. Comparing base ([`76d897e`](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3cf40a2`](https://app.codecov.io/gh/apache/superset/commit/3cf40a216afad41fa44f3440a3acfdc38feac87c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 3749 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/37974?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/db\_engine\_specs/athena.py](https://app.codecov.io/gh/apache/superset/pull/37974?src=pr&el=tree&filepath=superset%2Fdb_engine_specs%2Fathena.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/37974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #37974      +/-   ##
   ==========================================
   + Coverage   60.48%   65.87%   +5.38%     
   ==========================================
     Files        1931      668    -1263     
     Lines       76236    51323   -24913     
     Branches     8568     5776    -2792     
   ==========================================
   - Hits        46114    33808   -12306     
   + Misses      28017    16120   -11897     
   + Partials     2105     1395     -710     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/37974/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/37974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.47% <0.00%> (-7.69%)` | :arrow_down: |
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/37974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/37974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.49% <0.00%> (-12.32%)` | :arrow_down: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/37974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.85% <0.00%> (+2.35%)` | :arrow_up: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/37974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.20% <0.00%> (?)` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/37974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+42.36%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/37974?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(athena): pass schema to connect_args for PyAthena metadata discovery [superset]

Posted by "Arunodoy18 (via GitHub)" <gi...@apache.org>.
Arunodoy18 closed pull request #37974: fix(athena): pass schema to connect_args for PyAthena metadata discovery
URL: https://github.com/apache/superset/pull/37974


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org