[hive] branch master updated: HIVE-24011: Flaky test AsyncResponseHandlerTest ( Mustafa Iman via Ashutosh Chauhan)

[ha...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hashutosh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 5d9a5cf  HIVE-24011: Flaky test AsyncResponseHandlerTest ( Mustafa Iman via Ashutosh Chauhan)
5d9a5cf is described below

commit 5d9a5cf5a36c1d704d2671eb57547ea50249f28b
Author: Mustafa Iman <mu...@gmail.com>
AuthorDate: Fri Aug 7 13:56:49 2020 -0700

    HIVE-24011: Flaky test AsyncResponseHandlerTest ( Mustafa Iman via Ashutosh Chauhan)
    
    Timeout is too low. Also retry logic could cause "java.lang.IllegalArgumentException: timeout value is negative"
    
    Signed-off-by: Ashutosh Chauhan <ha...@apache.org>
---
 .../test/org/apache/hadoop/hive/llap/AsyncResponseHandlerTest.java  | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/llap-common/src/test/org/apache/hadoop/hive/llap/AsyncResponseHandlerTest.java b/llap-common/src/test/org/apache/hadoop/hive/llap/AsyncResponseHandlerTest.java
index 3d7bd90..d5d24cf 100644
--- a/llap-common/src/test/org/apache/hadoop/hive/llap/AsyncResponseHandlerTest.java
+++ b/llap-common/src/test/org/apache/hadoop/hive/llap/AsyncResponseHandlerTest.java
@@ -194,7 +194,7 @@ public class AsyncResponseHandlerTest {
   }
 
   private void assertTrueEventually(AssertTask assertTask) throws InterruptedException {
-    assertTrueEventually(assertTask, 10000);
+    assertTrueEventually(assertTask, 100000);
   }
 
   private void assertTrueEventually(AssertTask assertTask, int timeoutMillis) throws InterruptedException {
@@ -207,9 +207,7 @@ public class AsyncResponseHandlerTest {
         return;
       } catch (AssertionError e) {
         assertionError = e;
-        long millisUntilTimeout = endTime - System.currentTimeMillis();
-        sleep(millisUntilTimeout < 50 ? millisUntilTimeout : 50 );
-        continue;
+        sleep(50);
       }
     }
     throw assertionError;