You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/01/08 22:58:26 UTC
[kudu-CR] [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12183
Change subject: [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
......................................................................
[gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
As it turned out, most of the atomic operations functions
declared in atomicops-internals-macosx.h have been declared
deprecated at at 10.12 and higher.
This changelist adds 'pragma GCC diagnostic push/pop' for
the '-Wdeprecated-declarations' flag accordingly.
This is a follow-up to 678dbac6fb05d0370e40e6645d4b1ec530fa0180.
Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
---
M src/kudu/gutil/atomicops-internals-macosx.h
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/12183/1
--
To view, visit http://gerrit.cloudera.org:8080/12183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
Gerrit-Change-Number: 12183
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [gutil] suppress -Wdeprecated-declarations warning on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12183
to look at the new patch set (#3).
Change subject: [gutil] suppress -Wdeprecated-declarations warning on macOS
......................................................................
[gutil] suppress -Wdeprecated-declarations warning on macOS
As it turned out, most of the atomic functions used in
atomicops-internals-macosx.h have been declared deprecated since
macOS 10.12, most of the functions in the SASL API are deprecated
since macOS 10.11, and the krb5 API is deprecated in favor
of GSS.framework.
To avoid multiple compilation warnings on macOS while compiling
with clang from the Xcode development environment, this changelist adds
'pragma GCC diagnostic push/pop' for the '-Wdeprecated-declarations'
flag accordingly. It's confirmed that this patch suppresses
deprecation warnings at least on macOS 10.14.
This is a follow-up to 678dbac6fb05d0370e40e6645d4b1ec530fa0180.
Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
---
M src/kudu/gutil/atomicops-internals-macosx.h
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/init.cc
M src/kudu/thrift/sasl_client_transport.cc
8 files changed, 85 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/12183/3
--
To view, visit http://gerrit.cloudera.org:8080/12183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
Gerrit-Change-Number: 12183
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12183 )
Change subject: [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
......................................................................
Patch Set 2: Code-Review+2
Confirmed it eliminates the warnings on macOS 10.14.
--
To view, visit http://gerrit.cloudera.org:8080/12183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
Gerrit-Change-Number: 12183
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 00:15:06 +0000
Gerrit-HasComments: No
[kudu-CR] [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12183 )
Change subject: [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
Gerrit-Change-Number: 12183
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 08 Jan 2019 23:01:59 +0000
Gerrit-HasComments: No
[kudu-CR] [gutil] suppress -Wdeprecated-declarations warning on macOS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12183 )
Change subject: [gutil] suppress -Wdeprecated-declarations warning on macOS
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
Gerrit-Change-Number: 12183
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 00:27:23 +0000
Gerrit-HasComments: No
[kudu-CR] [gutil] suppress -Wdeprecated-declarations warning on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12183 )
Change subject: [gutil] suppress -Wdeprecated-declarations warning on macOS
......................................................................
[gutil] suppress -Wdeprecated-declarations warning on macOS
As it turned out, most of the atomic functions used in
atomicops-internals-macosx.h have been declared deprecated since
macOS 10.12, most of the functions in the SASL API are deprecated
since macOS 10.11, and the krb5 API is deprecated in favor
of GSS.framework.
To avoid multiple compilation warnings on macOS while compiling
with clang from the Xcode development environment, this changelist adds
'pragma GCC diagnostic push/pop' for the '-Wdeprecated-declarations'
flag accordingly. It's confirmed that this patch suppresses
deprecation warnings at least on macOS 10.14.
This is a follow-up to 678dbac6fb05d0370e40e6645d4b1ec530fa0180.
Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
Reviewed-on: http://gerrit.cloudera.org:8080/12183
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/gutil/atomicops-internals-macosx.h
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/init.cc
M src/kudu/thrift/sasl_client_transport.cc
8 files changed, 85 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
Gerrit-Change-Number: 12183
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12183
to look at the new patch set (#2).
Change subject: [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
......................................................................
[gutil] suppress -Wdeprecated-declarations on macOS >= 10.12
As it turned out, most of the atomic operations functions
declared in atomicops-internals-macosx.h have been declared
deprecated since macOS 10.12, most of the functions in the
SASL API are deprecated since macOS 10.11, and krb5 API
is deprecated in favor to GSS.framework.
This changelist adds 'pragma GCC diagnostic push/pop' for
the '-Wdeprecated-declarations' flag accordingly.
This is a follow-up to 678dbac6fb05d0370e40e6645d4b1ec530fa0180.
Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
---
M src/kudu/gutil/atomicops-internals-macosx.h
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/init.cc
M src/kudu/thrift/sasl_client_transport.cc
8 files changed, 83 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/12183/2
--
To view, visit http://gerrit.cloudera.org:8080/12183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860
Gerrit-Change-Number: 12183
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>