You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/06/05 22:22:04 UTC
[native-toolchain-CR] Add llvm 12 and 16
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20013
Change subject: Add llvm 12 and 16
......................................................................
Add llvm 12 and 16
Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
---
M buildall.sh
A source/llvm/build-unified-tarball.sh
M source/llvm/build.sh
3 files changed, 112 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/20013/1
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh@68
PS7, Line 68: export PYTHON3_VERSION=3.7.16
> Nit: Can we unset this after we're done with LLVM?
That's done by the (...) block. We have two different patterns for dependency version variables in this file. Do you want me to normalize on one?
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 16:35:34 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11459: Add LLVM 12
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20013
to look at the new patch set (#8).
Change subject: IMPALA-11459: Add LLVM 12
......................................................................
IMPALA-11459: Add LLVM 12
Add build for testing LLVM 12. LLVM 12 is a well-tested stable release
that predates function removal for opaque pointers.
Excludes building some parts of LLVM, similar to what Kudu does in
https://github.com/apache/kudu/blob/master/thirdparty/build-definitions.sh.
Carries run-clang-tidy patch to quiet script output. Other patches are
no longer necessary thanks to:
- https://github.com/llvm/llvm-project/commit/bebcd6fa4d2cb
- https://github.com/llvm/llvm-project/commit/965c5812f4380
- https://github.com/llvm/llvm-project/commit/3cbf3c8412890
- https://github.com/llvm/llvm-project/commit/383fe5c8668f6
- https://github.com/llvm/llvm-project/commit/18805ea951be0
- https://github.com/llvm/llvm-project/commit/947f969244083
- https://github.com/llvm/llvm-project/commit/9e68b734d6d0a
- https://github.com/llvm/llvm-project/commit/884040db08693
- https://github.com/llvm/llvm-project/commit/cc08a27d2ecc1
Makes cloudflarezlib/build.sh consistent with others to fix
line 38: return: can only `return' from a function or sourced script
Excludes libicu from Boost for build environments where icu is
installed.
Testing: successful build on all target platforms (RHEL 7/8, Ubuntu
16.04/18.04/20.04, SLES 12/15).
Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
---
M buildall.sh
M source/boost/build.sh
M source/cloudflarezlib/build.sh
M source/llvm/build-source-tarball.sh
A source/llvm/build-unified-tarball.sh
M source/llvm/build.sh
A source/llvm/llvm-12.0.1-patches/0001-Quiet-run-clang-tidy-invocation-output.patch
7 files changed, 300 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/20013/8
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11459: Add llvm 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20013
to look at the new patch set (#3).
Change subject: IMPALA-11459: Add llvm 12 and 16
......................................................................
IMPALA-11459: Add llvm 12 and 16
Add builds for testing LLVM 12 and 16. 12 retains deprecated functions
that we still rely on and has undergone some testing, while 16 is the
latest available release.
Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
---
M buildall.sh
A source/llvm/build-unified-tarball.sh
M source/llvm/build.sh
3 files changed, 112 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/20013/3
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20013
to look at the new patch set (#5).
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
IMPALA-11459: Add LLVM 12 and 16
Add builds for testing LLVM 12 and 16. 12 retains deprecated functions
that we still rely on and has undergone some testing, while 16 is the
latest available release.
Carries run-clang-tidy patch to quiet script output. Other patches are
no longer necessary thanks to:
- https://github.com/llvm/llvm-project/commit/bebcd6fa4d2cb
- https://github.com/llvm/llvm-project/commit/965c5812f4380
- https://github.com/llvm/llvm-project/commit/3cbf3c8412890
- https://github.com/llvm/llvm-project/commit/383fe5c8668f6
- https://github.com/llvm/llvm-project/commit/18805ea951be0
- https://github.com/llvm/llvm-project/commit/947f969244083
- https://github.com/llvm/llvm-project/commit/9e68b734d6d0a
Testing: successful build on all target platforms (RHEL 7/8, Ubuntu
16.04/18.04/20.04, SLES 12/15).
Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
---
M buildall.sh
A source/llvm/build-unified-tarball.sh
M source/llvm/build.sh
A source/llvm/llvm-12.0.1-patches/0001-Quiet-run-clang-tidy-invocation-output.patch
A source/llvm/llvm-16.0.5-patches/0001-Quiet-run-clang-tidy-invocation-output.patch
5 files changed, 170 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/20013/5
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh@68
PS7, Line 68: export PYTHON3_VERSION=3.7.16
> That's done by the (...) block. We have two different patterns for dependen
Oh, ok, I didn't realize the (...) block covered it. Then, you can ignore my comment.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 17:01:52 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11459: Add LLVM 12
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh@69
PS7, Line 69: LLVM_VERSION=12.0.1-p1 $SOURCE_DIR/source/llvm/build.sh
> This substantially increases build time. Going to settle on one to build fo
15 removes a bunch of functions that we'll need to adapt to. Sticking with just 12 for now as I test out some other changes to see if they improve compile time.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Jul 2023 21:39:59 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20013/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20013/6//COMMIT_MSG@14
PS6, Line 14: no longer necessary thanks to:
> Need to check patches 6 and 7.
Both are fixed in LLVM 12.0.1.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 18:50:03 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh@69
PS7, Line 69: LLVM_VERSION=12.0.1-p1 $SOURCE_DIR/source/llvm/build.sh
This substantially increases build time. Going to settle on one to build for now - maybe LLVM 15, which supports both opaque and typed pointers.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Jul 2023 16:46:22 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20013
to look at the new patch set (#4).
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
IMPALA-11459: Add LLVM 12 and 16
Add builds for testing LLVM 12 and 16. 12 retains deprecated functions
that we still rely on and has undergone some testing, while 16 is the
latest available release.
Testing: successful build on all target platforms (RHEL 7/8, Ubuntu
16.04/18.04/20.04, SLES 12/15).
Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
---
M buildall.sh
A source/llvm/build-unified-tarball.sh
M source/llvm/build.sh
3 files changed, 112 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/20013/4
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 7:
One thing to look into is that Kudu turns off a bunch of pieces of the LLVM build. Maybe we can turn off some of the same things to save some build time?
https://github.com/apache/kudu/blob/master/thirdparty/build-definitions.sh#L199-L269
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Jul 2023 17:46:09 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20013
to look at the new patch set (#6).
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
IMPALA-11459: Add LLVM 12 and 16
Add builds for testing LLVM 12 and 16. 12 retains deprecated functions
that we still rely on and has undergone some testing, while 16 is the
latest available release.
Carries run-clang-tidy patch to quiet script output. Other patches are
no longer necessary thanks to:
- https://github.com/llvm/llvm-project/commit/bebcd6fa4d2cb
- https://github.com/llvm/llvm-project/commit/965c5812f4380
- https://github.com/llvm/llvm-project/commit/3cbf3c8412890
- https://github.com/llvm/llvm-project/commit/383fe5c8668f6
- https://github.com/llvm/llvm-project/commit/18805ea951be0
- https://github.com/llvm/llvm-project/commit/947f969244083
- https://github.com/llvm/llvm-project/commit/9e68b734d6d0a
Testing: successful build on all target platforms (RHEL 7/8, Ubuntu
16.04/18.04/20.04, SLES 12/15).
Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
---
M buildall.sh
A source/llvm/build-unified-tarball.sh
M source/llvm/build.sh
A source/llvm/llvm-12.0.1-patches/0001-Quiet-run-clang-tidy-invocation-output.patch
A source/llvm/llvm-16.0.5-patches/0001-Quiet-run-clang-tidy-invocation-output.patch
5 files changed, 170 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/20013/6
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 4:
I have a custom patch on LLVM 5's clang-tidy that reduces the output noise substantially. It's something that we didn't merge upstream. It would be nice to preserve going forward. I believe the other patches have been addressed in LLVM 12, but we can check.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Jun 2023 23:46:44 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20013/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20013/6//COMMIT_MSG@14
PS6, Line 14: no longer necessary thanks to:
Need to check patches 6 and 7.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 18:40:16 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 7: Code-Review+1
Ok, cool, as long as this builds successfully, I think this change looks good.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 17:03:54 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/20013/7/buildall.sh@68
PS7, Line 68: export PYTHON3_VERSION=3.7.16
Nit: Can we unset this after we're done with LLVM?
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 16:32:23 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 7:
My build succeeded this time. So not sure what blip we ran into for Kudu builds.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 20:27:53 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11459: Add llvm 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add llvm 12 and 16
......................................................................
IMPALA-11459: Add llvm 12 and 16
Add builds for testing LLVM 12 and 16. 12 retains deprecated functions
that we still rely on and has undergone some testing, while 16 is the
latest available release.
Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
---
M buildall.sh
A source/llvm/build-unified-tarball.sh
M source/llvm/build.sh
3 files changed, 112 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/20013/2
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20013
to look at the new patch set (#7).
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
IMPALA-11459: Add LLVM 12 and 16
Add builds for testing LLVM 12 and 16. 12 retains deprecated functions
that we still rely on and has undergone some testing, while 16 is the
latest available release.
Carries run-clang-tidy patch to quiet script output. Other patches are
no longer necessary thanks to:
- https://github.com/llvm/llvm-project/commit/bebcd6fa4d2cb
- https://github.com/llvm/llvm-project/commit/965c5812f4380
- https://github.com/llvm/llvm-project/commit/3cbf3c8412890
- https://github.com/llvm/llvm-project/commit/383fe5c8668f6
- https://github.com/llvm/llvm-project/commit/18805ea951be0
- https://github.com/llvm/llvm-project/commit/947f969244083
- https://github.com/llvm/llvm-project/commit/9e68b734d6d0a
- https://github.com/llvm/llvm-project/commit/884040db08693
- https://github.com/llvm/llvm-project/commit/cc08a27d2ecc1
Testing: successful build on all target platforms (RHEL 7/8, Ubuntu
16.04/18.04/20.04, SLES 12/15).
Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
---
M buildall.sh
A source/llvm/build-unified-tarball.sh
M source/llvm/build.sh
A source/llvm/llvm-12.0.1-patches/0001-Quiet-run-clang-tidy-invocation-output.patch
A source/llvm/llvm-16.0.5-patches/0001-Quiet-run-clang-tidy-invocation-output.patch
5 files changed, 170 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/20013/7
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11459: Add LLVM 12 and 16
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20013 )
Change subject: IMPALA-11459: Add LLVM 12 and 16
......................................................................
Patch Set 4:
> Patch Set 4:
>
> I have a custom patch on LLVM 5's clang-tidy that reduces the output noise substantially. It's something that we didn't merge upstream. It would be nice to preserve going forward. I believe the other patches have been addressed in LLVM 12, but we can check.
I've confirmed patches 2-5 are all present in LLVM 12. I'll add back patch 1 for clang-tidy.
--
To view, visit http://gerrit.cloudera.org:8080/20013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6911a5915707c32aab6b4424b6c6127ba984c0
Gerrit-Change-Number: 20013
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 18:41:17 +0000
Gerrit-HasComments: No