[GitHub] [flink] twalthr commented on a diff in pull request #20633: [FLINK-29014][streaming-java][table] Improve end-to-end story about PipelinesOptions.JARS

[GitBox <gi...@apache.org>]

twalthr commented on code in PR #20633:
URL: https://github.com/apache/flink/pull/20633#discussion_r952398207


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java:
##########
@@ -152,6 +156,26 @@ public Set<URL> getLocalJarResources() {
                 .collect(Collectors.toSet());
     }
 
+    /**
+     * Adds the local jar resources to the given {@link TableConfig}. It implicitly considers the
+     * {@link TableConfig#getRootConfiguration()} and stores the merged result into {@link
+     * TableConfig#getConfiguration()}.
+     */
+    public void addJarConfiguration(TableConfig tableConfig) {
+        final List<String> jars =
+                getLocalJarResources().stream().map(URL::toString).collect(Collectors.toList());
+        if (jars.isEmpty()) {
+            return;
+        }
+        final Set<String> jarFiles =
+                tableConfig
+                        .getOptional(PipelineOptions.JARS)
+                        .map(HashSet::new)

Review Comment:
   Good catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org