[jira] [Comment Edited] (IGNITE-8154) Add an ability to provide ExceptionListener to JmsStreamer

["Valentin Kulichenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440339#comment-16440339 ] 

Valentin Kulichenko edited comment on IGNITE-8154 at 4/19/18 4:47 PM:
----------------------------------------------------------------------

[~antkr], please replace {{U.warn}} with {{U.error}} so that the whole stack trace is logged in case of exception.

In the test, you should avoid loops that can possibly never finish, like these ones:
{code}
while(lsnrExceptions.isEmpty())
    Thread.sleep(200);
{code}
Instead, you should have a {{CountDownLatch}} that is counted down from the exception listener. Test itself should then call {{await()}} with a timeout and assert that it returns {{true}}.


was (Author: vkulichenko):
[~antkr], please replace `U.warn` with `U.error` so that the whole stack trace is logged in case of exception.

In the test, you should avoid loops that can possibly never finish, like these ones:
{code}
while(lsnrExceptions.isEmpty())
    Thread.sleep(200);
{code}
Instead, you should have a {CountDownLatch} that is counted down from the exception listener. Test itself should then call `await()` with a timeout and assert that it returns `true`.

> Add an ability to provide ExceptionListener to JmsStreamer
> ----------------------------------------------------------
>
>                 Key: IGNITE-8154
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8154
>             Project: Ignite
>          Issue Type: Improvement
>          Components: streaming
>    Affects Versions: 2.4
>            Reporter: Valentin Kulichenko
>            Assignee: Anton Kurbanov
>            Priority: Major
>             Fix For: 2.6
>
>
> JMS API allows to provide custom {{ExceptionListener}} that is invoked when an exception occurs within JMS queue/topic. Currently, {{JmsStreamer}} doesn't use this in any way which creates two issues:
> * If there is an exception, it's lost and not even logged.
> * User can't provide their own listener.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)