You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2008/04/12 15:33:37 UTC
svn commit: r647446 -
/maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
Author: vsiveton
Date: Sat Apr 12 06:33:37 2008
New Revision: 647446
URL: http://svn.apache.org/viewvc?rev=647446&view=rev
Log:
o sort versions
Modified:
maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
Modified: maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java?rev=647446&r1=647445&r2=647446&view=diff
==============================================================================
--- maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java (original)
+++ maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java Sat Apr 12 06:33:37 2008
@@ -347,6 +347,8 @@
artifact.setAvailableVersions( versions );
}
+ Collections.sort( versions );
+
VersionRange versionRange = artifact.getVersionRange();
version = versionRange.matchVersion( versions );
Re: svn commit: r647446 - /maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
Posted by Vincent Siveton <vi...@gmail.com>.
Hi Brett,
2008/4/12, Brett Porter <br...@apache.org>:
> Vincet,
>
> I don't see these merged back to trunk?
It is on my TODO list. I need to investigate again to be sure. (see MNG-3518)
>
> Also, it'd be really helpful to add tests for these changes.
Same thing :)
Cheers,
Vincent
>
> Thanks,
> Brett
>
>
> On 12/04/2008, at 11:33 PM, vsiveton@apache.org wrote:
>
>
> > Author: vsiveton
> > Date: Sat Apr 12 06:33:37 2008
> > New Revision: 647446
> >
> > URL: http://svn.apache.org/viewvc?rev=647446&view=rev
> > Log:
> > o sort versions
> >
> > Modified:
> >
> maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
> >
> > Modified:
> maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
> > URL:
> http://svn.apache.org/viewvc/maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java?rev=647446&r1=647445&r2=647446&view=diff
> >
> ==============================================================================
> > ---
> maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
> (original)
> > +++
> maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
> Sat Apr 12 06:33:37 2008
> > @@ -347,6 +347,8 @@
> > artifact.setAvailableVersions( versions
> );
> > }
> >
> > + Collections.sort( versions );
> > +
> > VersionRange versionRange =
> artifact.getVersionRange();
> >
> > version = versionRange.matchVersion(
> versions );
> >
> >
> >
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r647446 - /maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
Posted by Brett Porter <br...@apache.org>.
Vincet,
I don't see these merged back to trunk?
Also, it'd be really helpful to add tests for these changes.
Thanks,
Brett
On 12/04/2008, at 11:33 PM, vsiveton@apache.org wrote:
> Author: vsiveton
> Date: Sat Apr 12 06:33:37 2008
> New Revision: 647446
>
> URL: http://svn.apache.org/viewvc?rev=647446&view=rev
> Log:
> o sort versions
>
> Modified:
> maven/components/branches/maven-2.0.x/maven-artifact/src/main/
> java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
>
> Modified: maven/components/branches/maven-2.0.x/maven-artifact/src/
> main/java/org/apache/maven/artifact/resolver/
> DefaultArtifactCollector.java
> URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.0.x/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java?rev=647446&r1=647445&r2=647446&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/components/branches/maven-2.0.x/maven-artifact/src/main/
> java/org/apache/maven/artifact/resolver/
> DefaultArtifactCollector.java (original)
> +++ maven/components/branches/maven-2.0.x/maven-artifact/src/main/
> java/org/apache/maven/artifact/resolver/
> DefaultArtifactCollector.java Sat Apr 12 06:33:37 2008
> @@ -347,6 +347,8 @@
>
> artifact.setAvailableVersions( versions );
> }
>
> + Collections.sort( versions );
> +
> VersionRange versionRange =
> artifact.getVersionRange();
>
> version =
> versionRange.matchVersion( versions );
>
>
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org