You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/24 00:00:54 UTC

[GitHub] [superset] codecov[bot] edited a comment on pull request #14225: feat: a native SQLAlchemy dialect for Superset

codecov[bot] edited a comment on pull request #14225:
URL: https://github.com/apache/superset/pull/14225#issuecomment-825997830


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14225?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14225](https://codecov.io/gh/apache/superset/pull/14225?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e40a06) into [master](https://codecov.io/gh/apache/superset/commit/aada73302fe0544d8e10786337b180be2852bfe4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aada733) will **increase** coverage by `0.02%`.
   > The diff coverage is `86.87%`.
   
   > :exclamation: Current head 4e40a06 differs from pull request most recent head eb3cd3a. Consider uploading reports for the commit eb3cd3a to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14225/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14225      +/-   ##
   ==========================================
   + Coverage   76.95%   76.98%   +0.02%     
   ==========================================
     Files         954      956       +2     
     Lines       48174    48333     +159     
     Branches     5977     5977              
   ==========================================
   + Hits        37074    37210     +136     
   - Misses      10903    10926      +23     
     Partials      197      197              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `81.09% <86.87%> (+0.02%)` | :arrow_up: |
   | postgres | `81.12% <86.87%> (+0.02%)` | :arrow_up: |
   | python | `81.20% <86.87%> (+0.02%)` | :arrow_up: |
   | sqlite | `80.73% <86.87%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/superset.py](https://codecov.io/gh/apache/superset/pull/14225/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3N1cGVyc2V0LnB5) | `86.27% <86.27%> (ø)` | |
   | [superset/db\_engine\_specs/gsheets.py](https://codecov.io/gh/apache/superset/pull/14225/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2dzaGVldHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/shillelagh.py](https://codecov.io/gh/apache/superset/pull/14225/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NoaWxsZWxhZ2gucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/security/analytics\_db\_safety.py](https://codecov.io/gh/apache/superset/pull/14225/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc2VjdXJpdHkvYW5hbHl0aWNzX2RiX3NhZmV0eS5weQ==) | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14225?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14225?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aada733...eb3cd3a](https://codecov.io/gh/apache/superset/pull/14225?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org