You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/30 08:22:28 UTC
[GitHub] [incubator-shardingsphere] zjcnb opened a new pull request #5002:
add start-index and stop-index for LiteralExpressionSegment
zjcnb opened a new pull request #5002: add start-index and stop-index for LiteralExpressionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/5002
Fixes #4781.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#5002: add start-index and stop-index for LiteralExpressionSegment
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5002: add start-index and stop-index for LiteralExpressionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/5002#issuecomment-605884386
## Pull Request Test Coverage Report for [Build 10708](https://coveralls.io/builds/29708813)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **45** unchanged lines in **5** files lost coverage.
* Overall coverage increased (+**0.2%**) to **57.331%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29708813/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L95) | 2 | 85.11% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaData.java](https://coveralls.io/builds/29708813/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaData.java#L72) | 2 | 92.86% |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java](https://coveralls.io/builds/29708813/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingTableMetaDataDecorator.java#L54) | 5 | 0% |
| [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/WalEventConverter.java](https://coveralls.io/builds/29708813/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2Fwal%2FWalEventConverter.java#L52) | 14 | 0% |
| [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/MySQLBinlogReader.java](https://coveralls.io/builds/29708813/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FMySQLBinlogReader.java#L51) | 22 | 0% |
<!-- | **Total:** | **45** | | -->
| Totals | [](https://coveralls.io/builds/29708813) |
| :-- | --: |
| Change from base [Build 10702](https://coveralls.io/builds/29702082): | 0.2% |
| Covered Lines: | 11738 |
| Relevant Lines: | 20474 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #5002: add start-index and stop-index for LiteralExpressionSegment
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5002: add start-index and stop-index for LiteralExpressionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/5002#discussion_r400102559
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/delete.xml
##########
@@ -6,7 +6,7 @@
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
- ~
+ ~delete_with_alias
Review comment:
Please do not change copyright
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5002: add
start-index and stop-index for LiteralExpressionSegment
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5002: add start-index and stop-index for LiteralExpressionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/5002#issuecomment-605884386
## Pull Request Test Coverage Report for [Build 10703](https://coveralls.io/builds/29703753)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.178%**
---
| Totals | [](https://coveralls.io/builds/29703753) |
| :-- | --: |
| Change from base [Build 10702](https://coveralls.io/builds/29702082): | 0.0% |
| Covered Lines: | 11730 |
| Relevant Lines: | 20515 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5002: add
start-index and stop-index for LiteralExpressionSegment
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5002: add start-index and stop-index for LiteralExpressionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/5002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] zjcnb commented on a change in pull
request #5002: add start-index and stop-index for LiteralExpressionSegment
Posted by GitBox <gi...@apache.org>.
zjcnb commented on a change in pull request #5002: add start-index and stop-index for LiteralExpressionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/5002#discussion_r400132215
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/delete.xml
##########
@@ -6,7 +6,7 @@
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
- ~
+ ~delete_with_alias
Review comment:
ok, i fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services