You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by lynchlee <gi...@git.apache.org> on 2015/07/19 16:28:11 UTC
[GitHub] incubator-usergrid pull request: change nameRegEx,removing the sla...
GitHub user lynchlee opened a pull request:
https://github.com/apache/incubator-usergrid/pull/312
change nameRegEx,removing the slash[/]
see jira issues USERGRID-868 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lynchlee/incubator-usergrid USERGRID-868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #312
----
commit 0f12f17ea6a0ebbc944bba3fa8e36bfd20980ccd
Author: Lynch Lee <ly...@gmail.com>
Date: 2015-07-19T14:24:31Z
change nameRegEx,removing the slash[/]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: change nameRegEx,removing the sla...
Posted by GERey <gi...@git.apache.org>.
Github user GERey commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/312#issuecomment-130469787
Yes I agree @lynchlee and I can merge this into 1.0.2 but since most people are directed to the master branch that is where it would get the most visibility it is suggested that you point this PR to master instead. We base our releases off of master so a PR to master would also go into future releases instead of just having a single PR to the 1.0.2 branch. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: change nameRegEx,removing the sla...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/312#issuecomment-124862689
this should probably target master, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: change nameRegEx,removing the sla...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/312#issuecomment-130471457
The 1.0.2 release already occurred. We don't re-release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: change nameRegEx,removing the sla...
Posted by lynchlee <gi...@git.apache.org>.
Github user lynchlee commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/312#issuecomment-129863038
Hi Johnament, thx . I checked out a new branch from the branch "1.0.2", and do some fixes , so i targeted 1.0.2 . right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---