You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by calavera <gi...@git.apache.org> on 2016/05/13 21:00:58 UTC
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
GitHub user calavera opened a pull request:
https://github.com/apache/trafficserver/pull/638
[TS-4444] Prevent segfault dealocating a NULL buffer_reader.
Signed-off-by: David Calavera <da...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/calavera/trafficserver fix_null_reference_in_tunnel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/638.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #638
----
commit 0f3548015c062def879a1dcb0cb57b38daeea2de
Author: David Calavera <da...@gmail.com>
Date: 2016-05-13T20:47:14Z
Prevent segfault dealocating a NULL buffer_reader.
Signed-off-by: David Calavera <da...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219497534
Does this only happen on SSL connections? We're seeing something strange related to IOBuffers and SSL connections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219303077
@shinrich Can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219194908
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219184123
Testing one more manual comment post.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by calavera <gi...@git.apache.org>.
Github user calavera commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219170498
@bgaff https://issues.apache.org/jira/browse/TS-4444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219429642
I'm ok with this change. It does solve the immediate problem, but I fear that this may be a symptom of a broader issue. I spent some time this winter tracking down read buffers that were going NULL in the midst of a transaction. That problem ultimately was the result of a race condition that was freeing the underlying iobuffer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219158266
--none--
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219169447
Can you provide a TS ticket or some explanation of what triggers this? Have you seen a crash associated with this code path, if so, can you share the backtrace?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219873200
The TS-3612 commit resulted into significant restructuring resulting in new issues or adjusting timing to reveal latent issues. I'll take a look at the small post scenario.
For the disappearing buffer_reader problem, sounds like that is a broader issue covering http1.x and probably http2. I think this may be a latent issue since @oknet noted in the bug comments seeing a similar crash in 6.0.x (which is before the TS-3612 commit).
I'm going to go ahead and merge this commit, but file two more issues. One to track the short post problem and another to track the disappearing buffer reader problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219191857
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219190124
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219177619
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219581568
@shinrich , according to @calavera 's git bisect it's this commit: https://github.com/apache/trafficserver/commit/af76977adb9f3c0296a232688bbcb5a1421a6768, we're seeing a similar issue related to POSTS w/ HTTP/2 where read complete events aren't being fired on a VIO. I'm suspecting it's also related to this commit. Our situation seems to happen w/ small posts where the entire payload is sent in a single chunk. It definitely sounds like these two issues could be related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219183414
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219185118
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by calavera <gi...@git.apache.org>.
Github user calavera commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219578773
No, we've seen it without SSL enabled too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219186475
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219158048
--none--
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by calavera <gi...@git.apache.org>.
Github user calavera commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219493880
Yeah, I totally agree with @shinrich. I don't think the NULL reference is the real issue either. Unfortunately, my expertise with ATS code base and internal behavior is still quite limited to find a better immediate solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4444] Prevent segfault dealocating...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219303052
Passed CI build tests.
https://ci.trafficserver.apache.org/view/github/job/Github-FreeBSD/164/
https://ci.trafficserver.apache.org/view/github/job/Github-Linux/72/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---