You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/08/26 09:54:16 UTC

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18447#discussion_r212820641
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -950,6 +949,10 @@ setGeneric("grouping_bit", function(x) { standardGeneric("grouping_bit") })
     #' @name NULL
     setGeneric("grouping_id", function(x, ...) { standardGeneric("grouping_id") })
     
    +#' @rdname column_misc_functions
    +#' @name NULL
    +setGeneric("hash", function(x, ...) { standardGeneric("hash") })
    --- End diff --
    
    I would avoid unrelated changes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org