You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2016/11/04 22:36:10 UTC
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------
(Updated Nov. 4, 2016, 10:36 p.m.)
Review request for atlas.
Changes
-------
Create and update API changes to v1 backend
Bugs: ATLAS-1257
https://issues.apache.org/jira/browse/ATLAS-1257
Repository: atlas
Description
-------
EntitiesREST will talk to the ATLAS v1 backend by converting from
a. AtlasEntity to Referenceable
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is completely ready.
Diffs (updated)
-----
distro/src/bin/atlas_stop.py a2b1c31
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/AtlasTransientId.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463
intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java cd44318
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 95c3dd9
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityToReferenceableConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityToEntityConverterTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityValidators.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityvsReferenceValidator.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasInstanceValueValidation.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasPrimitiveValueValidator.java PRE-CREATION
Diff: https://reviews.apache.org/r/53316/diff/
Testing
-------
Pending - UTS in progress
REST layer testing is also pending
Thanks,
Suma Shivaprasad
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/#review155226
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java (line 56)
<https://reviews.apache.org/r/53316/#comment225067>
Instead of having all entities include 'transientId' attribute, how about treating guid values that start with "-" as transient? It will keep the structure of AtlasEntity cleaner.
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java (line 34)
<https://reviews.apache.org/r/53316/#comment225069>
Please review if changes in this file are necessary. If not needed, consider reverting this file.
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java (line 40)
<https://reviews.apache.org/r/53316/#comment225070>
Please review if changes in this file are necessary. If not needed, consider reverting this file.
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java (line 72)
<https://reviews.apache.org/r/53316/#comment225072>
This is duplicate of line #77. Please review and remove. If no changes are needed in this file, consider reverting this file.
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 56)
<https://reviews.apache.org/r/53316/#comment225080>
This implementation seems similar to AtlasArrayType.getNormalizedValue(Object obj) - which handles List/Set/built-in array value. Please review if it helps to handle built-in array.
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java (line 47)
<https://reviews.apache.org/r/53316/#comment225100>
Consider returning "type.getNormalizedValue(source)" - which return correct primitive type (Boolean/Integer/Double/String), after necessary convertions - if necessary.
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java (line 87)
<https://reviews.apache.org/r/53316/#comment225101>
source would be null here. Perhaps this else was meant to be for the 'if' at line #73?
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java (line 113)
<https://reviews.apache.org/r/53316/#comment225102>
Consider taking AtlasStructType as parameter, instead of Collection<AtlasStructDef.AtlasAttributeDef>.
AtlasStructType has a cache of AtlasType for each of its attribute - which can help eliminate typeRegistry.getType(attrTypeName) the need to instantiate AtlasArrayType and AtlasMapType (for array/map attributes).
- Madhan Neethiraj
On Nov. 4, 2016, 11:24 p.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53316/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2016, 11:24 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1257
> https://issues.apache.org/jira/browse/ATLAS-1257
>
>
> Repository: atlas
>
>
> Description
> -------
>
> EntitiesREST will talk to the ATLAS v1 backend by converting from
> a. AtlasEntity to Referenceable
> b. AtlasStruct to Struct
> c. Map of complex types
> d. Array of complex types
> and call the V1 backend directly as a workaround before v2 implementation is completely ready.
>
>
> Diffs
> -----
>
> distro/src/bin/atlas_stop.py a2b1c31
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
> intg/src/main/java/org/apache/atlas/model/instance/AtlasTransientId.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java cd44318
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 95c3dd9
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityToReferenceableConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
> webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityToEntityConverterTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityValidators.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityvsReferenceValidator.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/adapters/AtlasInstanceValueValidation.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/adapters/AtlasPrimitiveValueValidator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53316/diff/
>
>
> Testing
> -------
>
> Pending - UTS in progress
> REST layer - tested create and update through the new APIs
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/#review155268
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java (line 275)
<https://reviews.apache.org/r/53316/#comment225139>
It might be more efficient to check if the first character is "-", instead of parsing the entire string for long value. Please review.
private boolean isUnassigned() {
return guid != null && guid.size() > 0 && guid.getAt(0) == '-';
}
This approach would also make nextNegativeLong() implementation to become:
private static String nextInternalId() {
return "-" + Long.toString(s_nextId.getAndIncrement());
}
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 61)
<https://reviews.apache.org/r/53316/#comment225141>
AtlasType.getNormalizedValue() would only work if sourceVersion is V2 - it might not be able to handle 'source' object in V1 format. This call may not be necessary; consider using source directly.
Please review and update.
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 84)
<https://reviews.apache.org/r/53316/#comment225142>
isArrayListType() and isSetType() are duplicated in AtlasFormatConverters as well. Please review.
- Madhan Neethiraj
On Nov. 8, 2016, 5:48 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53316/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2016, 5:48 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1257
> https://issues.apache.org/jira/browse/ATLAS-1257
>
>
> Repository: atlas
>
>
> Description
> -------
>
> EntitiesREST will talk to the ATLAS v1 backend by converting from
> a. AtlasEntity to Referenceable
> b. AtlasStruct to Struct
> c. Map of complex types
> d. Array of complex types
> and call the V1 backend directly as a workaround before v2 implementation is completely ready.
>
>
> Diffs
> -----
>
> distro/src/bin/atlas_stop.py a2b1c31
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 82fe380
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
> webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
> webapp/src/test/java/org/apache/atlas/web/adapters/AtlasFormatValidators.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/adapters/TestAtlasEntitiesREST.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53316/diff/
>
>
> Testing
> -------
>
> Pending - UTS in progress
> REST layer - tested create and update through the new APIs
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------
(Updated Nov. 14, 2016, 8:54 p.m.)
Review request for atlas.
Changes
-------
Fixed review comments
Bugs: ATLAS-1257
https://issues.apache.org/jira/browse/ATLAS-1257
Repository: atlas
Description
-------
EntitiesREST will talk to the ATLAS v1 backend by converting from
a. AtlasEntity to Referenceable
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is completely ready.
Diffs (updated)
-----
distro/src/bin/atlas_stop.py a2b1c31
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 8e0d164
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java b88d4e8
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d
intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 37c2374
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasClassificationToTraitConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53316/diff/
Testing
-------
Added valid case UTs
REST layer - tested create and update through the new APIs
Have to add invalid case UTs
Thanks,
Suma Shivaprasad
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/#review155758
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java (line 30)
<https://reviews.apache.org/r/53316/#comment225843>
'registry' does not seem to be needed here. Please review and remove.
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java (line 57)
<https://reviews.apache.org/r/53316/#comment225844>
This comment does not look relevant here. Please review.
webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java (line 59)
<https://reviews.apache.org/r/53316/#comment225846>
'struct' could be null - AtlasStructToStructConverter.convert() returns null. Please review and add null checks.
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java (line 177)
<https://reviews.apache.org/r/53316/#comment225851>
Please add a TODO here, so that it is easier to find pending work.
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 142)
<https://reviews.apache.org/r/53316/#comment225850>
Same path is used for getById() and getWithAssociationsByGuid() - "/guid/{guid}". Please update.
getById() - "/guid/{guid}"
getWithAssociationsByGuid() - "/guid/withAssociations/{guid}"
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 217)
<https://reviews.apache.org/r/53316/#comment225849>
Consider moving 'private' methods to end of the file.
- Madhan Neethiraj
On Nov. 12, 2016, 12:24 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53316/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2016, 12:24 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1257
> https://issues.apache.org/jira/browse/ATLAS-1257
>
>
> Repository: atlas
>
>
> Description
> -------
>
> EntitiesREST will talk to the ATLAS v1 backend by converting from
> a. AtlasEntity to Referenceable
> b. AtlasStruct to Struct
> c. Map of complex types
> d. Array of complex types
> and call the V1 backend directly as a workaround before v2 implementation is completely ready.
>
>
> Diffs
> -----
>
> distro/src/bin/atlas_stop.py a2b1c31
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java b88d4e8
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 37c2374
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasClassificationToTraitConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
> webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
> webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53316/diff/
>
>
> Testing
> -------
>
> Added valid case UTs
> REST layer - tested create and update through the new APIs
> Have to add invalid case UTs
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------
(Updated Nov. 12, 2016, 12:24 a.m.)
Review request for atlas.
Bugs: ATLAS-1257
https://issues.apache.org/jira/browse/ATLAS-1257
Repository: atlas
Description
-------
EntitiesREST will talk to the ATLAS v1 backend by converting from
a. AtlasEntity to Referenceable
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is completely ready.
Diffs
-----
distro/src/bin/atlas_stop.py a2b1c31
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java b88d4e8
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d
intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 37c2374
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasClassificationToTraitConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53316/diff/
Testing (updated)
-------
Added valid case UTs
REST layer - tested create and update through the new APIs
Have to add invalid case UTs
Thanks,
Suma Shivaprasad
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------
(Updated Nov. 12, 2016, 12:24 a.m.)
Review request for atlas.
Changes
-------
Added implementation to talk to v1 backend for EntityREST - all CRUD operations except updateClassifications
Added impl for EntitiesREST except searchEntities
Bugs: ATLAS-1257
https://issues.apache.org/jira/browse/ATLAS-1257
Repository: atlas
Description
-------
EntitiesREST will talk to the ATLAS v1 backend by converting from
a. AtlasEntity to Referenceable
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is completely ready.
Diffs (updated)
-----
distro/src/bin/atlas_stop.py a2b1c31
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java b88d4e8
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d
intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 37c2374
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasClassificationToTraitConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53316/diff/
Testing
-------
Pending - UTS in progress
REST layer - tested create and update through the new APIs
Thanks,
Suma Shivaprasad
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/#review155684
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java (line 65)
<https://reviews.apache.org/r/53316/#comment225756>
If 'type' is of type AtlasEntityType, consider the following:
AtlasEntityDef entityDef = ((AtlasEntityType)type).getEntityDef();
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java (line 64)
<https://reviews.apache.org/r/53316/#comment225755>
If 'type' is of type AtlasStructType, consider the following:
AtlasStructDef structDef = ((AtlasStructType)type).getStructDef();
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java (line 87)
<https://reviews.apache.org/r/53316/#comment225757>
isn't 'type' parameter same as the 'entityType' here? Please review here and line #78.
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java (line 80)
<https://reviews.apache.org/r/53316/#comment225759>
Consider replacing with:
AtlasStructDef structDef = ((AtlasStructType)type).getStructDef();
- Madhan Neethiraj
On Nov. 11, 2016, 12:12 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53316/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2016, 12:12 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1257
> https://issues.apache.org/jira/browse/ATLAS-1257
>
>
> Repository: atlas
>
>
> Description
> -------
>
> EntitiesREST will talk to the ATLAS v1 backend by converting from
> a. AtlasEntity to Referenceable
> b. AtlasStruct to Struct
> c. Map of complex types
> d. Array of complex types
> and call the V1 backend directly as a workaround before v2 implementation is completely ready.
>
>
> Diffs
> -----
>
> distro/src/bin/atlas_stop.py a2b1c31
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 37c2374
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
> webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
> webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e
> webapp/src/test/java/org/apache/atlas/web/adapters/TestAtlasEntitiesREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53316/diff/
>
>
> Testing
> -------
>
> Pending - UTS in progress
> REST layer - tested create and update through the new APIs
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------
(Updated Nov. 11, 2016, 12:12 a.m.)
Review request for atlas.
Changes
-------
Added further test which checks after serializing/deserialixing the entity which happens when we call the REST APIs so that the conversion to map for attributes is also tested
Bugs: ATLAS-1257
https://issues.apache.org/jira/browse/ATLAS-1257
Repository: atlas
Description
-------
EntitiesREST will talk to the ATLAS v1 backend by converting from
a. AtlasEntity to Referenceable
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is completely ready.
Diffs (updated)
-----
distro/src/bin/atlas_stop.py a2b1c31
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d
intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 37c2374
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e
webapp/src/test/java/org/apache/atlas/web/adapters/TestAtlasEntitiesREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53316/diff/
Testing
-------
Pending - UTS in progress
REST layer - tested create and update through the new APIs
Thanks,
Suma Shivaprasad
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------
(Updated Nov. 10, 2016, 11:33 p.m.)
Review request for atlas.
Changes
-------
Fixed review comments
Bugs: ATLAS-1257
https://issues.apache.org/jira/browse/ATLAS-1257
Repository: atlas
Description
-------
EntitiesREST will talk to the ATLAS v1 backend by converting from
a. AtlasEntity to Referenceable
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is completely ready.
Diffs (updated)
-----
distro/src/bin/atlas_stop.py a2b1c31
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d
intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 37c2374
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e
webapp/src/test/java/org/apache/atlas/web/adapters/TestAtlasEntitiesREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53316/diff/
Testing
-------
Pending - UTS in progress
REST layer - tested create and update through the new APIs
Thanks,
Suma Shivaprasad
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------
(Updated Nov. 8, 2016, 5:48 a.m.)
Review request for atlas.
Changes
-------
Added changes for GETs. Test changes pending
Bugs: ATLAS-1257
https://issues.apache.org/jira/browse/ATLAS-1257
Repository: atlas
Description
-------
EntitiesREST will talk to the ATLAS v1 backend by converting from
a. AtlasEntity to Referenceable
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is completely ready.
Diffs (updated)
-----
distro/src/bin/atlas_stop.py a2b1c31
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463
intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 69e8d12
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 82fe380
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java bbf01a6
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasFormatValidators.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/TestAtlasEntitiesREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53316/diff/
Testing
-------
Pending - UTS in progress
REST layer - tested create and update through the new APIs
Thanks,
Suma Shivaprasad
Re: Review Request 53316: Initial draft of changes for ATLAS Entities
REST to talk to v1 backend
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------
(Updated Nov. 4, 2016, 11:24 p.m.)
Review request for atlas.
Bugs: ATLAS-1257
https://issues.apache.org/jira/browse/ATLAS-1257
Repository: atlas
Description
-------
EntitiesREST will talk to the ATLAS v1 backend by converting from
a. AtlasEntity to Referenceable
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is completely ready.
Diffs
-----
distro/src/bin/atlas_stop.py a2b1c31
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/AtlasTransientId.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463
intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java cd44318
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 95c3dd9
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityToReferenceableConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityToEntityConverterTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityValidators.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityvsReferenceValidator.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasInstanceValueValidation.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/adapters/AtlasPrimitiveValueValidator.java PRE-CREATION
Diff: https://reviews.apache.org/r/53316/diff/
Testing (updated)
-------
Pending - UTS in progress
REST layer - tested create and update through the new APIs
Thanks,
Suma Shivaprasad