[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435275#comment-16435275 ] 

ASF GitHub Bot commented on ZOOKEEPER-3019:
-------------------------------------------

GitHub user nkalmar opened a pull request:

    https://github.com/apache/zookeeper/pull/501

    ZOOKEEPER-3019 add metric for slow fsyncs count

    Added metric to count fsyncWarningThresholdMS exceed in FileTxnLog.commit(). Both jmx bean and Command can be used to get the stat.
    
    Also updated the python standalone client and documentation.
    
    Tested the py script, i.e.:
    src/contrib/monitoring/check_zookeeper.py -o cacti -s "localhost:2181" -k zk_num_alive_connections
    localhost_2181:1
    
    rc/contrib/monitoring/check_zookeeper.py -o cacti -s "localhost:2181" -k zk_fsync_threshold_exceed_count
    localhost_2181:0
    
    mntr command now returns:
    zk_version	3.6.0-SNAPSHOT-13c9f899ff62be6a2eacb28e522d06703f1dab08, built on 04/04/2018 12:09 GMT
    zk_avg_latency	0
    zk_max_latency	0
    zk_min_latency	0
    zk_packets_received	7
    zk_packets_sent	6
    zk_num_alive_connections	1
    zk_outstanding_requests	0
    zk_server_state	standalone
    zk_znode_count	5
    zk_watch_count	0
    zk_ephemerals_count	0
    zk_approximate_data_size	44
    zk_open_file_descriptor_count	61
    zk_max_file_descriptor_count	10240
    zk_fsync_threshold_exceed_count	0

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3019

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #501
    
----
commit 8b575c879d45f28a34670bcb20cc4fd196dee008
Author: Norbert Kalmar <nk...@...>
Date:   2018-04-11T15:24:09Z

    ZOOKEEPER-3019 add metric to track slow fsyncs count + update py script and docs

----


> Add a metric to track number of slow fsyncs
> -------------------------------------------
>
>                 Key: ZOOKEEPER-3019
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx, server
>    Affects Versions: 3.5.3, 3.4.11
>            Reporter: Norbert Kalmar
>            Assignee: Norbert Kalmar
>            Priority: Major
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)