You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2019/06/25 07:47:08 UTC

[GitHub] [camel-k] nicolaferraro commented on a change in pull request #765: Add timeout to maven operations

nicolaferraro commented on a change in pull request #765: Add timeout to maven operations
URL: https://github.com/apache/camel-k/pull/765#discussion_r297049109
 
 

 ##########
 File path: pkg/controller/integrationplatform/initialize.go
 ##########
 @@ -132,12 +132,20 @@ func (action *initializeAction) Handle(ctx context.Context, ip *v1alpha1.Integra
 	if target.Spec.Build.PersistentVolumeClaim == "" {
 		target.Spec.Build.PersistentVolumeClaim = target.Name
 	}
+	if target.Spec.Build.Maven.Timeout.Duration == 0 {
+		target.Spec.Build.Maven.Timeout.Duration = 2 * time.Minute
 
 Review comment:
   I know that everything is restarted, but I'd increase this to 5 mins because first run is always slow if you don't have a quick network. Wdyt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services