[GitHub] [drill] vvysotskyi commented on a change in pull request #2048: DRILL-7429: Wrong column order when selecting complex data using Hive storage plugin

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #2048: DRILL-7429: Wrong column order when selecting complex data using Hive storage plugin
URL: https://github.com/apache/drill/pull/2048#discussion_r403732045
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
 ##########
 @@ -339,6 +331,14 @@ protected IterOutcome handleNullInput() {
     return IterOutcome.OK_NEW_SCHEMA;
   }
 
+  private boolean isNotSchemalessInput() {
+    RecordBatch incomingBatch = incoming instanceof IteratorValidatorBatchIterator
+        ? ((IteratorValidatorBatchIterator) incoming).getIncoming()
+        : incoming;
 
 Review comment:
   Is it required to ensure that incoming batch after `IteratorValidatorBatchIterator` is `IteratorValidatorBatchIterator`?
   
   Looks like `SchemalessBatch.getSchema()` always returns null, so at least the second check covers this `instance of` check...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services