You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/19 10:38:14 UTC

[GitHub] [flink] killxdcj opened a new pull request #10900: [FLINK-15549][API/DataSet] Fix Integer overflow in ResettableIterator.

killxdcj opened a new pull request #10900: [FLINK-15549][API/DataSet] Fix Integer overflow in ResettableIterator.
URL: https://github.com/apache/flink/pull/10900
 
 
   ## What is the purpose of the change
   
   The ResettableIterator has a data overflow problem if the number of elements in a single input exceeds Integer.MAX_VALUE. This pull request intend to fix this problem.
   
   ## Brief change log
   
     - *Fix Integer overflow in ResettableIterator*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10900: [FLINK-15549][API/DataSet] Fix Integer overflow in ResettableIterator.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10900: [FLINK-15549][API/DataSet] Fix Integer overflow in ResettableIterator.
URL: https://github.com/apache/flink/pull/10900#issuecomment-575991186
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8bc0e386e12b2b8af8f6245de0630c7210c13fba (Sun Jan 19 10:41:05 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] killxdcj closed pull request #10900: [FLINK-15549][API/DataSet] Fix Integer overflow in ResettableIterator.

Posted by GitBox <gi...@apache.org>.
killxdcj closed pull request #10900: [FLINK-15549][API/DataSet] Fix Integer overflow in ResettableIterator.
URL: https://github.com/apache/flink/pull/10900
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10900: [FLINK-15549][API/DataSet] Fix Integer overflow in ResettableIterator.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10900: [FLINK-15549][API/DataSet] Fix Integer overflow in ResettableIterator.
URL: https://github.com/apache/flink/pull/10900#issuecomment-575994003
 
 
   <!--
   Meta data
   Hash:8bc0e386e12b2b8af8f6245de0630c7210c13fba Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8bc0e386e12b2b8af8f6245de0630c7210c13fba
   -->
   ## CI report:
   
   * 8bc0e386e12b2b8af8f6245de0630c7210c13fba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services