You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lukecwik <gi...@git.apache.org> on 2017/04/25 20:06:26 UTC
[GitHub] beam pull request #2678: [BEAM-1871] Move Bigquery/Pubsub options to sdks/ja...
GitHub user lukecwik opened a pull request:
https://github.com/apache/beam/pull/2678
[BEAM-1871] Move Bigquery/Pubsub options to sdks/java/io/google-cloud-platform
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Note that I duplicated and hid certain methods which create Pubsub/Bigquery clients to limit type visibility in the public API surface.
Also note that I moved the BigqueryMatcher from src/main to src/test and into the io/gcp module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam thin_sdk_core3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2678
----
commit d70caf5bf29c16bedc778dd57135f1a6eec4b005
Author: Luke Cwik <lc...@google.com>
Date: 2017-04-24T22:58:47Z
[BEAM-1871] Move Bigquery/Pubsub options to sdks/java/io/google-cloud-platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2678: [BEAM-1871] Move Bigquery/Pubsub options to sdks/ja...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2678
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---