You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/05/16 10:49:37 UTC

[GitHub] [echarts] stephenLYZ opened a new pull request #14957: feat(tree): add tree path info to tooltip

stephenLYZ opened a new pull request #14957:
URL: https://github.com/apache/echarts/pull/14957


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   Add tree path info to the tooltip as Treemap.
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   Fixes #8800 
   
   ## Details
   
   ### Before: What was the problem?
   ![image](https://user-images.githubusercontent.com/11830681/118394411-2bf87a00-b677-11eb-9620-bcd929ea10d8.png)
   
   The path of the tooltip cannot be customized
   
   
   ### After: How is it fixed in this PR?
   ![image](https://user-images.githubusercontent.com/11830681/118394437-4df1fc80-b677-11eb-9206-dcb1ed20dac0.png)
   
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   tree-basic.html
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] stephenLYZ commented on a change in pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on a change in pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#discussion_r633468831



##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Agreed. Thanks for the suggestion.

##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Agreed. Thanks for the suggestion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#discussion_r633353150



##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Ignore the fact that the internal method has been named `wrapTreePathInfo`, is it better to call this property `treeAncestors` when providing to developers? `path` can mean from an arbitrary node to another arbitrary node.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#issuecomment-841800280


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#issuecomment-842802804


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14957:
URL: https://github.com/apache/echarts/pull/14957


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#discussion_r633353150



##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Ignore the fact that the internal method has been named `wrapTreePathInfo`, is it better to call this property `treeAncestors` when providing to developers? `path` can mean from an arbitrary node to another arbitrary node.

##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Ignore the fact that the internal method has been named `wrapTreePathInfo`, is it better to call this property `treeAncestors` when providing to developers? `path` can be from an arbitrary node to another arbitrary node.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] stephenLYZ commented on a change in pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on a change in pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#discussion_r633468831



##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Agreed. Thanks for the suggestion.

##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Agreed. Thanks for the suggestion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#issuecomment-841800280


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#discussion_r633353150



##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Ignore the fact that the internal method has been named `wrapTreePathInfo`, is it better to call this property `treeAncestors` when providing to developers? `path` can be from an arbitrary node to another arbitrary node.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] stephenLYZ commented on a change in pull request #14957: feat(tree): add tree path info to tooltip

Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on a change in pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#discussion_r633468831



##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Agreed. Thanks for the suggestion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org