You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2015/10/01 02:04:33 UTC

[GitHub] spark pull request: [SPARK-9818][SQL][WIP]Revert SPARK-6136 to ena...

Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/8101#issuecomment-144578314
  
    I'd like to help get this patch merged so that we can re-run these tests, but before we put a lot more work into polishing it I would like to figure out whether our regular Jenkins build is the right place to run these tests.
    
    These tests are fairly heavyweight to run (since they have to download a bunch of Docker images) and might add significant amounts of time to the test runs. Therefore, I think we should skip them for the majority of pull requests and should only run them when JDBC-related code is changed (maybe just code under the `jdbc/` directory).
    
    Similarly, we may not want to run these tests as part of every master build. Over time, I imagine that we'll accumulate larger-and-larger regression test suites here and they're going to add a huge cost for most builds. Therefore, I think that we should try to tag these suites so that they're not run as part of most master builds but are only run once per day or something like that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org