[GitHub] [tvm] mehrdadh commented on a diff in pull request #12368: [Hexagon] Add skip option for RPC server initialization

[GitBox <gi...@apache.org>]

mehrdadh commented on code in PR #12368:
URL: https://github.com/apache/tvm/pull/12368#discussion_r943682940


##########
python/tvm/contrib/hexagon/pytest_plugin.py:
##########
@@ -260,9 +261,21 @@ def aot_target(aot_host_target):
         assert False, "Incorrect AoT host target: {aot_host_target}. Options are [c, llvm]."
 
 
+@pytest.fixture(scope="session")
+def skip_rpc(request) -> bool:
+    return request.config.getoption("--skip-rpc")
+
+
 def pytest_addoption(parser):
     parser.addoption("--gtest_args", action="store", default="")
 
+    parser.addoption(
+        "--skip-rpc",
+        action="store_true",
+        default=False,
+        help="If set true, a new hexagon launcher is not created",

Review Comment:
   You can make it more clear by changing to this:
   If set true, the RPC server initialization on Android would be skipped.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org