You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2026/10/10 13:39:56 UTC
[GH] (rocketmq-dashboard/codex/alert-domain-legacy-v2): Workflow run "CI" failed!
The GitHub Actions job "CI" on rocketmq-dashboard.git/codex/alert-domain-legacy-v2 has failed.
Run started by GitHub user tju-yxq (triggered by tju-yxq).
Head commit for run:
6ccd2b426d9b5a14b84bd9fe9275674af6aca9cd / Yxq <30...@tju.edu.cn>
fix(alert): include legacy NULL-domain alert events in the business feed filter
The paged alert feed filters domain with a plain equality
(.eq("domain", "BUSINESS")), but the rmq_system_alert domain column was
introduced by AlertSchemaMigration as a plain nullable VARCHAR(16) — no
default, no backfill — so every alert event recorded before the upgrade
keeps domain = NULL. parseDomain reads NULL as BUSINESS and the
non-paged listAlerts filters in memory after that default, so those
legacy events appear in the unpaginated feed yet vanish from the paged
feed as soon as domain=BUSINESS is selected; the two endpoints disagree
for the same filter. findRelatedAlerts hits the same miss when it loads
related business alerts for a cluster incident.
Mirror the findRulesPage treatment: filtering BUSINESS matches
domain IS NULL OR domain = 'BUSINESS' (the rule-side comment already
documents this exact convention for pre-domain rows), while any other
domain keeps the exact equality. The stable ORDER BY time DESC,id DESC
is unchanged.
Report URL: https://github.com/apache/rocketmq-dashboard/actions/runs/38055946772
With regards,
GitHub Actions via GitBox