[GitHub] [arrow] kou commented on a diff in pull request #35032: GH-34656: [CI][Python] Fix Windows wheel upload to gemfury

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #35032:
URL: https://github.com/apache/arrow/pull/35032#discussion_r1167263574


##########
dev/tasks/macros.jinja:
##########
@@ -131,16 +131,14 @@ on:
 {% endmacro %}
 
 {%- macro github_upload_gemfury(pattern) -%}
-  {%- if arrow.is_default_branch() -%}
   - name: Upload package to Gemfury
     shell: bash
     run: |
+      gem install --user-install gemfury
       path=$(ls {{ pattern }})
-      curl -F "package=@${path}" https://${CROSSBOW_GEMFURY_TOKEN}@push.fury.io/${CROSSBOW_GEMFURY_ORG}/
+      ruby arrow/ci/scripts/gemfury_upload.rb ${path}

Review Comment:
   How about using `fury` command installed by `gem install --user-install gemfury` instead of creating a custom command?
   
   ```shell
   PATH=$(ruby -r rubygems -e 'puts Gem.user_dir')/bin:$PATH
   gem install --user-install gemfury
   fury \
     --api-token=${CROSSBOW_GEMFURY_TOKEN} \
     --as=${CROSSBOW_GEMFURY_ORG} \
     {{ pattern }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org