You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by da...@apache.org on 2006/10/28 12:16:38 UTC
svn commit: r468669 -
/cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java
Author: danielf
Date: Sat Oct 28 03:16:36 2006
New Revision: 468669
URL: http://svn.apache.org/viewvc?view=rev&rev=468669
Log:
Improve error reporting by using a CascadingIOException instead of an ordinary IOException. Due to Alexander Klimetschek.
Modified:
cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java
Modified: cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java
URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java?view=diff&rev=468669&r1=468668&r2=468669
==============================================================================
--- cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java (original)
+++ cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java Sat Oct 28 03:16:36 2006
@@ -30,6 +30,7 @@
import javax.servlet.ServletException;
import org.apache.avalon.framework.logger.Logger;
+import org.apache.cocoon.CascadingIOException;
import org.apache.cocoon.blocks.util.BlockCallHttpServletRequest;
import org.apache.cocoon.blocks.util.BlockCallHttpServletResponse;
@@ -118,7 +119,7 @@
return new ByteArrayInputStream(out);
} catch (ServletException e) {
- throw new IOException("BlockConnection " + e.getMessage());
+ throw new CascadingIOException("BlockConnection " + e.getMessage());
}
}
Re: svn commit: r468669 - /cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java
Posted by Daniel Fagerstrom <da...@nada.kth.se>.
Joerg Heinicke skrev:
> On 28.10.2006 12:16, danielf@apache.org wrote:
>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=468669
>> Log:
>> Improve error reporting by using a CascadingIOException instead of an
>> ordinary IOException. Due to Alexander Klimetschek.
>>
>> Modified:
>>
>> cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java
>>
>
>> return new ByteArrayInputStream(out);
>> } catch (ServletException e) {
>> - throw new IOException("BlockConnection " + e.getMessage());
>> + throw new CascadingIOException("BlockConnection " +
>> e.getMessage());
>
> But I guess it has to be
>
> new CascadingIOException("BlockConnection " + e.getMessage(), e);
>
> to be of real advantage.
>
> Jörg
Fixed, thanks.
/Daniel
Re: svn commit: r468669 - /cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java
Posted by Joerg Heinicke <jo...@gmx.de>.
On 28.10.2006 12:16, danielf@apache.org wrote:
> URL: http://svn.apache.org/viewvc?view=rev&rev=468669
> Log:
> Improve error reporting by using a CascadingIOException instead of an ordinary IOException. Due to Alexander Klimetschek.
>
> Modified:
> cocoon/trunk/core/cocoon-blocks-fw/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockConnection.java
>
> return new ByteArrayInputStream(out);
> } catch (ServletException e) {
> - throw new IOException("BlockConnection " + e.getMessage());
> + throw new CascadingIOException("BlockConnection " + e.getMessage());
But I guess it has to be
new CascadingIOException("BlockConnection " + e.getMessage(), e);
to be of real advantage.
Jörg