You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Tilman Hausherr (JIRA)" <ji...@apache.org> on 2017/07/09 16:17:02 UTC

[jira] [Commented] (PDFBOX-3854) PDDeviceRGB.toRGBImage should return a RGB-Typed-Image

    [ https://issues.apache.org/jira/browse/PDFBOX-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079655#comment-16079655 ] 

Tilman Hausherr commented on PDFBOX-3854:
-----------------------------------------

last two commits belong to (related issue :-) ) PDFBOX-3860

> PDDeviceRGB.toRGBImage should return a RGB-Typed-Image
> ------------------------------------------------------
>
>                 Key: PDFBOX-3854
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3854
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel, Rendering
>    Affects Versions: 2.0.6
>            Reporter: Yannick Haser
>            Assignee: Tilman Hausherr
>              Labels: optimization
>             Fix For: 2.0.7, 3.0.0
>
>         Attachments: rgbImageExample0.pdf, rgbImageSecondExample.pdf, Starter2.java, Starter.java
>
>
> While converting a PDPage to a BufferedImage (using the PDFRenderer) Images-Resources located in the PDPage gets loaded in a WriteableRaster and a given Colorspace.
> These get converted to a BufferedImage (with PDDeviceRGB.toRGBImage()). But the Type of the returing BufferedImage is with the given Raster and Colorspace always from Type "BufferedImage.TYPE_CUSTOM" instead of the expected "BufferedImage.TYPE_INT_RGB" for example.
> Consequences:
> Image-Processing-Operations with/on BufferedImages with TYPE_CUSTOM are not optimized in Java (slower) and partialy runs through "Synchronized" Blocks.
> ==> Converting different Documents in different Threads are blocking each other.
> "Quick"-Fix for seeing a Performance-Improvement in a Multithreading Environment:
> {code:title=PDDeviceRGB.java|borderStyle=solid}
> @Override
> public BufferedImage toRGBImage(WritableRaster raster) throws IOException {
> 	init();
> 	ColorModel colorModel = new ComponentColorModel(awtColorSpace, false, false, Transparency.OPAQUE,
> 			raster.getDataBuffer().getDataType());
> 	BufferedImage image = new BufferedImage(colorModel, raster, false, null);
> 	BufferedImage dest = new BufferedImage(image.getWidth(), image.getHeight(), BufferedImage.TYPE_INT_RGB);
> 	ColorConvertOp op = new ColorConvertOp(dest.getColorModel().getColorSpace(), null);
> 	return op.filter(image, dest);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org