You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/15 05:34:02 UTC
[GitHub] [incubator-druid] clintropolis opened a new pull request #8310:
exclude kerberos extension dependencies that are already included in druid
core libraries
clintropolis opened a new pull request #8310: exclude kerberos extension dependencies that are already included in druid core libraries
URL: https://github.com/apache/incubator-druid/pull/8310
### Description
While working on `NOTICE` stuff for 0.16.0, noticed kerberos extension had a lot of dependencies that were already included in `lib/` folder of package, so I have excluded them from the kerberos extension pom.
before:
<img width="546" alt="Screen Shot 2019-08-14 at 8 55 21 PM" src="https://user-images.githubusercontent.com/1577461/63071873-e1f8c800-bed5-11e9-9c3b-77a33859cac6.png">
```
$ ls -1
apacheds-i18n-2.0.0-M15.jar
apacheds-kerberos-codec-2.0.0-M15.jar
api-asn1-api-1.0.0-M20.jar
api-util-1.0.0-M20.jar
commons-beanutils-1.7.0.jar
commons-beanutils-core-1.8.0.jar
commons-collections-3.2.2.jar
commons-compress-1.18.jar
commons-configuration-1.6.jar
commons-digester-1.8.jar
commons-net-3.6.jar
druid-kerberos-0.16.0-incubating-SNAPSHOT.jar
gson-2.2.4.jar
hadoop-auth-2.8.3.jar
hadoop-common-2.8.3.jar
htrace-core4-4.0.1-incubating.jar
jackson-jaxrs-1.9.2.jar
jackson-xc-1.9.2.jar
java-xmlbuilder-0.4.jar
javax.activation-api-1.2.0.jar
javax.servlet-api-3.1.0.jar
jaxb-api-2.3.1.jar
jaxb-impl-2.2.3-1.jar
jcip-annotations-1.0.jar
jersey-json-1.19.3.jar
jersey-server-1.19.3.jar
jets3t-0.9.0.jar
jettison-1.1.jar
jetty-6.1.26.jar
jetty-client-9.4.10.v20180503.jar
jetty-continuation-9.4.10.v20180503.jar
jetty-http-9.4.10.v20180503.jar
jetty-io-9.4.10.v20180503.jar
jetty-proxy-9.4.10.v20180503.jar
jetty-security-9.4.10.v20180503.jar
jetty-server-9.4.10.v20180503.jar
jetty-servlet-9.4.10.v20180503.jar
jetty-servlets-9.4.10.v20180503.jar
jetty-sslengine-6.1.26.jar
jetty-util-9.4.10.v20180503.jar
jsch-0.1.54.jar
json-smart-1.1.1.jar
jsp-api-2.1.jar
nimbus-jose-jwt-3.9.jar
servlet-api-2.5.jar
xmlenc-0.52.jar
```
after:
<img width="769" alt="Screen Shot 2019-08-14 at 8 22 41 PM" src="https://user-images.githubusercontent.com/1577461/63070859-ba9ffc00-bed1-11e9-9282-a465530daa96.png">
```
$ ls -1
apacheds-i18n-2.0.0-M15.jar
apacheds-kerberos-codec-2.0.0-M15.jar
api-asn1-api-1.0.0-M20.jar
api-util-1.0.0-M20.jar
commons-beanutils-core-1.8.0.jar
commons-configuration-1.6.jar
druid-kerberos-0.16.0-incubating-SNAPSHOT.jar
gson-2.2.4.jar
hadoop-auth-2.8.3.jar
hadoop-common-2.8.3.jar
htrace-core4-4.0.1-incubating.jar
jackson-jaxrs-1.9.2.jar
jackson-xc-1.9.2.jar
java-xmlbuilder-0.4.jar
javax.activation-api-1.2.0.jar
jaxb-api-2.3.1.jar
jaxb-impl-2.2.3-1.jar
jcip-annotations-1.0.jar
jersey-json-1.19.3.jar
jersey-server-1.19.3.jar
jets3t-0.9.0.jar
jettison-1.1.jar
jsch-0.1.54.jar
json-smart-1.1.1.jar
jsp-api-2.1.jar
nimbus-jose-jwt-3.9.jar
xmlenc-0.52.jar
```
Looking at the actual classes the production dependencies use, this change appears safe to me, but I haven't tested for reals...
<img width="559" alt="Screen Shot 2019-08-14 at 10 32 21 PM" src="https://user-images.githubusercontent.com/1577461/63074734-6f8ee480-bee3-11e9-86b1-57bf6de8b2e8.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org