You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/06/14 03:03:55 UTC
[GitHub] activemq-artemis pull request #2140: ARTEMIS-1931
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2140
ARTEMIS-1931
I had this laying around on a local branch for a long time so I decided to clean it up and send a PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1931
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2140
----
commit d960d266fe2f4d2150e32340a765a3b74bce157f
Author: Justin Bertram <jb...@...>
Date: 2017-11-17T18:19:27Z
ARTEMIS-1931 Support web dependencies in 'create' plugin
commit 68bec05b5c410f1f0e900677e0f671d7b5dcf07a
Author: Justin Bertram <jb...@...>
Date: 2017-11-17T18:29:05Z
ARTEMIS-1931 Support property replacement in CLI plugin
commit 409d76ec43114d05e9c7d4fc2f06a51563730a5d
Author: Justin Bertram <jb...@...>
Date: 2017-11-17T18:29:48Z
ARTEMIS-1931 Add camel example
----
---
[GitHub] activemq-artemis pull request #2140: ARTEMIS-1931
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2140#discussion_r195422277
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/process/ProcessBuilder.java ---
@@ -64,7 +65,7 @@ public static void cleanupProcess() {
* @return
* @throws Exception
*/
- public static Process build(String logname, File location, boolean hook, String... args) throws Exception {
+ public static Process build(String logname, File location, boolean hook, String[] args, String[] properties) throws Exception {
--- End diff --
You can see how it's used in the Camel example that I added. See the camel-broker/pom.xml:
```
<properties>
<!-- define the "war" property so it can be used in bootstrap.xml -->
<param>war=camel-war-${project.version}.war</param>
</properties>
```
Keep in mind, this is a change used by the Maven plugin as it is the only user of org.apache.activemq.artemis.cli.process.ProcessBuilder#build. There's no help information for the plugin that I'm aware of.
---
[GitHub] activemq-artemis pull request #2140: ARTEMIS-1931
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2140#discussion_r195413408
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/process/ProcessBuilder.java ---
@@ -64,7 +65,7 @@ public static void cleanupProcess() {
* @return
* @throws Exception
*/
- public static Process build(String logname, File location, boolean hook, String... args) throws Exception {
+ public static Process build(String logname, File location, boolean hook, String[] args, String[] properties) throws Exception {
--- End diff --
How do you use this?
---
[GitHub] activemq-artemis pull request #2140: ARTEMIS-1931
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2140#discussion_r195433936
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/process/ProcessBuilder.java ---
@@ -64,7 +65,7 @@ public static void cleanupProcess() {
* @return
* @throws Exception
*/
- public static Process build(String logname, File location, boolean hook, String... args) throws Exception {
+ public static Process build(String logname, File location, boolean hook, String[] args, String[] properties) throws Exception {
--- End diff --
From the cli itself.. say I wanted to start a server with -D<xmlconfigproperty=something>
it would be nice to have a way to define those properties from artemis run as well
---
[GitHub] activemq-artemis pull request #2140: ARTEMIS-1931
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2140#discussion_r195438606
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/process/ProcessBuilder.java ---
@@ -64,7 +65,7 @@ public static void cleanupProcess() {
* @return
* @throws Exception
*/
- public static Process build(String logname, File location, boolean hook, String... args) throws Exception {
+ public static Process build(String logname, File location, boolean hook, String[] args, String[] properties) throws Exception {
--- End diff --
That would be nice, but I don't see how that's possible given how org.apache.activemq.artemis.cli.commands.Run actually works. In any case, I think it's beyond this PR.
---
[GitHub] activemq-artemis issue #2140: ARTEMIS-1931
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2140
Camel example!!!! nice!!!!!!
---
[GitHub] activemq-artemis pull request #2140: ARTEMIS-1931
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2140#discussion_r195413668
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/process/ProcessBuilder.java ---
@@ -64,7 +65,7 @@ public static void cleanupProcess() {
* @return
* @throws Exception
*/
- public static Process build(String logname, File location, boolean hook, String... args) throws Exception {
+ public static Process build(String logname, File location, boolean hook, String[] args, String[] properties) throws Exception {
--- End diff --
I mean that also: how that translate to the CLI help stuff? any way we can add some information how it's used?
---
[GitHub] activemq-artemis pull request #2140: ARTEMIS-1931
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2140
---