You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/03/27 20:29:58 UTC
Review Request 57969: Pig exectype default value seems to be not
changing after upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57969/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
Bugs: AMBARI-20597
https://issues.apache.org/jira/browse/AMBARI-20597
Repository: ambari
Description
-------
PIG in HDP 2.6 changes the default engine in {{pig-properties/content}} from MapR to Tez:
{code}
exectype=tez
{code}
However, HDP upgrades are not working correctly because of a problem with the upgrade configuration pack:
{code}
<definition xsi:type="configure" id="hdp_2_6_0_0_pig_use_tez">
<type>pig-properties</type>
<replace key="exectype" find="exectype=mapreduce" replace-with="exectype=tez" />
</definition>
{code}
There is no key named {{exectype}} in {{pig-properties}} ... there is only {{pig-properties/content}}. This key needs to be changed to find/replace
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 5f135e9
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 3c309ce
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml f908654
Diff: https://reviews.apache.org/r/57969/diff/1/
Testing
-------
Manual upgrade...
Thanks,
Jonathan Hurley
Re: Review Request 57969: Pig exectype default value seems to be not
changing after upgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57969/#review170230
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 27, 2017, 8:29 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57969/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 8:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20597
> https://issues.apache.org/jira/browse/AMBARI-20597
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PIG in HDP 2.6 changes the default engine in {{pig-properties/content}} from MapR to Tez:
>
> {code}
> exectype=tez
> {code}
>
> However, HDP upgrades are not working correctly because of a problem with the upgrade configuration pack:
>
> {code}
> <definition xsi:type="configure" id="hdp_2_6_0_0_pig_use_tez">
> <type>pig-properties</type>
> <replace key="exectype" find="exectype=mapreduce" replace-with="exectype=tez" />
> </definition>
> {code}
>
> There is no key named {{exectype}} in {{pig-properties}} ... there is only {{pig-properties/content}}. This key needs to be changed to find/replace
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 5f135e9
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 3c309ce
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml f908654
>
>
> Diff: https://reviews.apache.org/r/57969/diff/1/
>
>
> Testing
> -------
>
> Manual upgrade...
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 57969: Pig exectype default value seems to be not
changing after upgrade
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57969/#review170225
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On March 27, 2017, 4:29 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57969/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 4:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20597
> https://issues.apache.org/jira/browse/AMBARI-20597
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PIG in HDP 2.6 changes the default engine in {{pig-properties/content}} from MapR to Tez:
>
> {code}
> exectype=tez
> {code}
>
> However, HDP upgrades are not working correctly because of a problem with the upgrade configuration pack:
>
> {code}
> <definition xsi:type="configure" id="hdp_2_6_0_0_pig_use_tez">
> <type>pig-properties</type>
> <replace key="exectype" find="exectype=mapreduce" replace-with="exectype=tez" />
> </definition>
> {code}
>
> There is no key named {{exectype}} in {{pig-properties}} ... there is only {{pig-properties/content}}. This key needs to be changed to find/replace
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 5f135e9
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 3c309ce
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml f908654
>
>
> Diff: https://reviews.apache.org/r/57969/diff/1/
>
>
> Testing
> -------
>
> Manual upgrade...
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 57969: Pig exectype default value seems to be not
changing after upgrade
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57969/
-----------------------------------------------------------
(Updated March 27, 2017, 7:09 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
Bugs: AMBARI-20597
https://issues.apache.org/jira/browse/AMBARI-20597
Repository: ambari
Description
-------
PIG in HDP 2.6 changes the default engine in {{pig-properties/content}} from MapR to Tez:
{code}
exectype=tez
{code}
However, HDP upgrades are not working correctly because of a problem with the upgrade configuration pack:
{code}
<definition xsi:type="configure" id="hdp_2_6_0_0_pig_use_tez">
<type>pig-properties</type>
<replace key="exectype" find="exectype=mapreduce" replace-with="exectype=tez" />
</definition>
{code}
There is no key named {{exectype}} in {{pig-properties}} ... there is only {{pig-properties/content}}. This key needs to be changed to find/replace
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 5f135e9
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 3c309ce
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml f908654
Diff: https://reviews.apache.org/r/57969/diff/3/
Changes: https://reviews.apache.org/r/57969/diff/2-3/
Testing
-------
Manual upgrade...
Thanks,
Jonathan Hurley
Re: Review Request 57969: Pig exectype default value seems to be not
changing after upgrade
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57969/
-----------------------------------------------------------
(Updated March 27, 2017, 5:52 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
Changes
-------
Turns out the default in HDP 2.6 is still not tez. This means if it's commented out, we still need to replace it:
# exectype=mapreduce
to
exectype=tez
exectype=mapreduce
to
exectype=tez
# exectype=mapreduce
to
exectype=tez
Bugs: AMBARI-20597
https://issues.apache.org/jira/browse/AMBARI-20597
Repository: ambari
Description
-------
PIG in HDP 2.6 changes the default engine in {{pig-properties/content}} from MapR to Tez:
{code}
exectype=tez
{code}
However, HDP upgrades are not working correctly because of a problem with the upgrade configuration pack:
{code}
<definition xsi:type="configure" id="hdp_2_6_0_0_pig_use_tez">
<type>pig-properties</type>
<replace key="exectype" find="exectype=mapreduce" replace-with="exectype=tez" />
</definition>
{code}
There is no key named {{exectype}} in {{pig-properties}} ... there is only {{pig-properties/content}}. This key needs to be changed to find/replace
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 5f135e9
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 3c309ce
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml f908654
Diff: https://reviews.apache.org/r/57969/diff/2/
Changes: https://reviews.apache.org/r/57969/diff/1-2/
Testing
-------
Manual upgrade...
Thanks,
Jonathan Hurley