You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/28 02:59:52 UTC

[GitHub] [incubator-druid] clintropolis commented on issue #8963: add flush timeout to emitter test

clintropolis commented on issue #8963: add flush timeout to emitter test
URL: https://github.com/apache/incubator-druid/pull/8963#issuecomment-559321985
 
 
   This PR seems to help. I have repeatedly run the "other modules test" several times and they have not failed once due to `EmitterTest`.
   
   I have noticed a handful of 
   ```
   [WARNING] org.apache.druid.java.util.emitter.core.EmitterTest.testTimeBasedEmission(org.apache.druid.java.util.emitter.core.EmitterTest)
   [ERROR]   Run 1: EmitterTest.testTimeBasedEmission:378->closeNoFlush:611 » IO Timed out after [...
   [INFO]   Run 2: PASS
   ```
   
   So I think this is good to merge and should help travis pass a bit more on the first time through

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org