You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/10 10:00:42 UTC
[GitHub] [shardingsphere] TeslaCN opened a new pull request, #19002: Use SPI to handle PostgreSQL SET variable behaviour
TeslaCN opened a new pull request, #19002:
URL: https://github.com/apache/shardingsphere/pull/19002
Fixes #18738.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #19002: Use SPI to handle PostgreSQL SET variable behaviour
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #19002:
URL: https://github.com/apache/shardingsphere/pull/19002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19002: Use SPI to handle PostgreSQL SET variable behaviour
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19002:
URL: https://github.com/apache/shardingsphere/pull/19002#issuecomment-1179703776
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19002?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19002](https://codecov.io/gh/apache/shardingsphere/pull/19002?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (817c3fd) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8f1ef8176e59ba45eaa7d13e9fde24aa1d2778b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f1ef81) will **increase** coverage by `0.00%`.
> The diff coverage is `93.75%`.
```diff
@@ Coverage Diff @@
## master #19002 +/- ##
=========================================
Coverage 59.41% 59.41%
- Complexity 2316 2318 +2
=========================================
Files 3797 3800 +3
Lines 54637 54644 +7
Branches 9237 9233 -4
=========================================
+ Hits 32460 32468 +8
- Misses 19451 19452 +1
+ Partials 2726 2724 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...resql/PostgreSQLSessionVariableHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/19002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL3Bvc3RncmVzcWwvUG9zdGdyZVNRTFNlc3Npb25WYXJpYWJsZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `75.00% <75.00%> (ø)` | |
| [...resql/DefaultPostgreSQLSessionVariableHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/19002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL3Bvc3RncmVzcWwvRGVmYXVsdFBvc3RncmVTUUxTZXNzaW9uVmFyaWFibGVIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...min/postgresql/PostgreSQLAdminExecutorCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/19002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL3Bvc3RncmVzcWwvUG9zdGdyZVNRTEFkbWluRXhlY3V0b3JDcmVhdG9yLmphdmE=) | `56.00% <100.00%> (-4.61%)` | :arrow_down: |
| [...postgresql/PostgreSQLSetVariableAdminExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/19002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL3Bvc3RncmVzcWwvUG9zdGdyZVNRTFNldFZhcmlhYmxlQWRtaW5FeGVjdXRvci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...tgresql/executor/PostgreSQLSetCharsetExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/19002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL3Bvc3RncmVzcWwvZXhlY3V0b3IvUG9zdGdyZVNRTFNldENoYXJzZXRFeGVjdXRvci5qYXZh) | `18.18% <100.00%> (+18.18%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19002?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19002?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f1ef81...817c3fd](https://codecov.io/gh/apache/shardingsphere/pull/19002?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org