You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/03 22:39:14 UTC
[GitHub] [incubator-superset] lilykuang opened a new pull request #9982: feat: implement secondary navigation for datasets
lilykuang opened a new pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r437938528
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Button, Nav, Navbar, MenuItem } from 'react-bootstrap';
Review comment:
There were some discussion when [SIP-34](https://github.com/apache/incubator-superset/issues/8976#issuecomment-590565931) was closed and I thought the general consensus was we wanted to at least move away from Bootstrap 3?
If we are to implement new UI components for the new design, it'd be the best to start clean and reduce dependencies on Bootstrap as much as possible, especially if the component doesn't need to reuse much styling from Bootstrap anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `6.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 64.83% -6.56%
==========================================
Files 585 531 -54
Lines 30949 29552 -1397
Branches 3261 2886 -375
==========================================
- Hits 22094 19159 -2935
- Misses 8746 10217 +1471
- Partials 109 176 +67
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.05% <ø> (-0.04%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| ... and [212 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...21cbf89](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] lilykuang commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
lilykuang commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r436859858
##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
}
}
}
+
+#secondary-menu {
+ margin-top: -20px;
+ .navbar-header .navbar-brand {
+ font-weight: @font-weight-bold;
+ }
+ .navbar-right {
+ .btn-default {
+ text-transform: uppercase;
+ font-weight: 500;
+ font-size: @font-size-s;
+ background-color: @brand-primary;
+ border-radius: 4px;
+ color: @lightest;
+ margin: 8px 43px;
+ padding: 8px 51px 8px 43px;
+ border: none;
+ i {
+ padding: 4px @font-size-xs;
+ }
+ }
+ }
+ .navbar-nav {
+ li {
+ a {
+ font-size: @font-size-s;
+ padding: 8px;
+ margin: 8px;
+ color: @gray-drak-heading;
+ }
+ }
+ li.active > a,
+ li > a:hover {
+ background-color: @gray-light-hover;
+ border-bottom: none;
+ border-radius: 4px;
+ }
+ }
+}
Review comment:
@ktmud good suggestion. I think moving to these to styled components will be cleaner. I will move css to the component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `5.91%`.
> The diff coverage is `86.95%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 65.47% -5.92%
==========================================
Files 585 586 +1
Lines 30949 31049 +100
Branches 3261 3281 +20
==========================================
- Hits 22094 20329 -1765
- Misses 8746 10539 +1793
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <86.95%> (+0.01%)` | :arrow_up: |
| #python | `69.75% <ø> (-1.82%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `87.50% <87.50%> (ø)` | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [191 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...d97a519](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r437938528
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Button, Nav, Navbar, MenuItem } from 'react-bootstrap';
Review comment:
There were some discussion when [SIP-34](https://github.com/apache/incubator-superset/issues/8976#issuecomment-590565931) was closed and I thought the general consensus is we want to at least move away from Bootstrap 3?
If we are to implement new UI components to new UI, it'd be the best to start clean and reduce dependencies on Bootstrap as much as possible, especially if the component doesn't need to reuse much styling from Bootstrap anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `4.89%`.
> The diff coverage is `86.95%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 66.49% -4.90%
==========================================
Files 585 586 +1
Lines 30949 30920 -29
Branches 3261 3271 +10
==========================================
- Hits 22094 20561 -1533
- Misses 8746 10179 +1433
- Partials 109 180 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <86.95%> (+0.04%)` | :arrow_up: |
| #python | `71.49% <ø> (-0.08%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `87.50% <87.50%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [164 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...88d3f46](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `86.95%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 70.21% -1.18%
==========================================
Files 585 586 +1
Lines 30949 31058 +109
Branches 3261 3281 +20
==========================================
- Hits 22094 21808 -286
- Misses 8746 9133 +387
- Partials 109 117 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.10% <ø> (-0.99%)` | :arrow_down: |
| #javascript | `59.41% <86.95%> (+0.01%)` | :arrow_up: |
| #python | `69.98% <ø> (-1.59%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `87.50% <87.50%> (ø)` | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <0.00%> (-14.83%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <0.00%> (-7.90%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.45% <0.00%> (-7.20%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| ... and [49 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...d97a519](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
+ Coverage 71.38% 71.51% +0.12%
==========================================
Files 585 184 -401
Lines 30949 18174 -12775
Branches 3261 0 -3261
==========================================
- Hits 22094 12997 -9097
+ Misses 8746 5177 -3569
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.51% <ø> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.38% <0.00%> (-0.22%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/components/Select/WindowedSelect/windowed.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L3dpbmRvd2VkLnRzeA==) | | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | | |
| ... and [404 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...4dd33f7](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r435409848
##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
}
}
}
+
+#secondary-menu {
+ margin-top: -20px;
+ .navbar-header .navbar-brand {
+ font-weight: @font-weight-bold;
+ }
+ .navbar-right {
+ .btn-default {
+ text-transform: uppercase;
+ font-weight: 500;
+ font-size: @font-size-s;
+ background-color: @brand-primary;
+ border-radius: 4px;
+ color: @lightest;
+ margin: 8px 43px;
+ padding: 8px 51px 8px 43px;
+ border: none;
+ i {
+ padding: 4px @font-size-xs;
+ }
+ }
+ }
+ .navbar-nav {
+ li {
+ a {
+ font-size: @font-size-s;
+ padding: 8px;
+ margin: 8px;
+ color: #3d3d3d;
Review comment:
Should this be a color variable?
##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
}
}
}
+
+#secondary-menu {
+ margin-top: -20px;
+ .navbar-header .navbar-brand {
+ font-weight: @font-weight-bold;
+ }
+ .navbar-right {
+ .btn-default {
+ text-transform: uppercase;
+ font-weight: 500;
+ font-size: @font-size-s;
+ background-color: @brand-primary;
+ border-radius: 4px;
+ color: @lightest;
+ margin: 8px 43px;
+ padding: 8px 51px 8px 43px;
+ border: none;
+ i {
+ padding: 4px @font-size-xs;
+ }
+ }
+ }
+ .navbar-nav {
+ li {
+ a {
+ font-size: @font-size-s;
+ padding: 8px;
+ margin: 8px;
+ color: #3d3d3d;
+ }
+ }
+ li.active > a,
+ li > a:hover {
+ background: #eceef2;
Review comment:
Same question - should this be a variable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
=======================================
Coverage 71.38% 71.39%
=======================================
Files 585 586 +1
Lines 30949 30984 +35
Branches 3261 3255 -6
=======================================
+ Hits 22094 22120 +26
- Misses 8746 8754 +8
- Partials 109 110 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.05% <ø> (-0.04%)` | :arrow_down: |
| #javascript | `59.43% <87.50%> (+0.04%)` | :arrow_up: |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.14% <85.71%> (+0.51%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `88.23% <88.23%> (ø)` | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.15% <0.00%> (-0.66%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...21cbf89](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
=======================================
Coverage 71.38% 71.38%
=======================================
Files 585 586 +1
Lines 30949 31003 +54
Branches 3261 3271 +10
=======================================
+ Hits 22094 22133 +39
- Misses 8746 8760 +14
- Partials 109 110 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.99% <ø> (-0.09%)` | :arrow_down: |
| #javascript | `59.44% <87.50%> (+0.05%)` | :arrow_up: |
| #python | `71.58% <ø> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `88.23% <88.23%> (ø)` | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `60.56% <0.00%> (-2.68%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...88d3f46](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 71.23% -0.16%
==========================================
Files 585 184 -401
Lines 30949 18092 -12857
Branches 3261 0 -3261
==========================================
- Hits 22094 12888 -9206
+ Misses 8746 5204 -3542
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.23% <ø> (-0.34%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <0.00%> (-2.34%)` | :arrow_down: |
| ... and [419 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...4dd33f7](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `86.95%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
=======================================
Coverage 71.38% 71.38%
=======================================
Files 585 586 +1
Lines 30949 31002 +53
Branches 3261 3271 +10
=======================================
+ Hits 22094 22132 +38
- Misses 8746 8760 +14
- Partials 109 110 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.99% <ø> (-0.09%)` | :arrow_down: |
| #javascript | `59.44% <86.95%> (+0.04%)` | :arrow_up: |
| #python | `71.58% <ø> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `87.50% <87.50%> (ø)` | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `60.56% <0.00%> (-2.68%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...88d3f46](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r436876552
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Button, Nav, Navbar, MenuItem } from 'react-bootstrap';
Review comment:
To me migrating away from bootstrap is an important decision with intricate considerations that are outside the scope of this PR. We should start a `[DISCUSS]` thread on the mailing list on this topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 71.09% -0.30%
==========================================
Files 585 586 +1
Lines 30949 30921 -28
Branches 3261 3271 +10
==========================================
- Hits 22094 21984 -110
- Misses 8746 8821 +75
- Partials 109 116 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.21% <ø> (-0.88%)` | :arrow_down: |
| #javascript | `59.44% <87.50%> (+0.05%)` | :arrow_up: |
| #python | `71.43% <ø> (-0.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `88.23% <88.23%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...c1d48b5](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r436330249
##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
}
}
}
+
+#secondary-menu {
+ margin-top: -20px;
+ .navbar-header .navbar-brand {
+ font-weight: @font-weight-bold;
+ }
+ .navbar-right {
+ .btn-default {
+ text-transform: uppercase;
+ font-weight: 500;
+ font-size: @font-size-s;
+ background-color: @brand-primary;
+ border-radius: 4px;
+ color: @lightest;
+ margin: 8px 43px;
+ padding: 8px 51px 8px 43px;
+ border: none;
+ i {
+ padding: 4px @font-size-xs;
+ }
+ }
+ }
+ .navbar-nav {
+ li {
+ a {
+ font-size: @font-size-s;
+ padding: 8px;
+ margin: 8px;
+ color: @gray-drak-heading;
+ }
+ }
+ li.active > a,
+ li > a:hover {
+ background-color: @gray-light-hover;
+ border-bottom: none;
+ border-radius: 4px;
+ }
+ }
+}
Review comment:
Hmm, should we move these to styled components or are we ok with living in a world with a mix of less + css-in-js?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `6.87%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 64.51% -6.88%
==========================================
Files 585 531 -54
Lines 30949 29552 -1397
Branches 3261 2886 -375
==========================================
- Hits 22094 19066 -3028
- Misses 8746 10302 +1556
- Partials 109 184 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.23% <ø> (-0.86%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| ... and [214 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...21cbf89](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
+ Coverage 71.38% 71.58% +0.19%
==========================================
Files 585 184 -401
Lines 30949 18174 -12775
Branches 3261 0 -3261
==========================================
- Hits 22094 13009 -9085
+ Misses 8746 5165 -3581
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...oard/components/gridComponents/new/NewMarkdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdNYXJrZG93bi5qc3g=) | | |
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | | |
| [...nd/src/messageToasts/components/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | | |
| ... and [401 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...21cbf89](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.96%`.
> The diff coverage is `86.95%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 70.42% -0.97%
==========================================
Files 585 586 +1
Lines 30949 31058 +109
Branches 3261 3281 +20
==========================================
- Hits 22094 21872 -222
- Misses 8746 9075 +329
- Partials 109 111 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.94% <ø> (-0.15%)` | :arrow_down: |
| #javascript | `59.41% <86.95%> (+0.01%)` | :arrow_up: |
| #python | `69.98% <ø> (-1.59%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `87.50% <87.50%> (ø)` | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <0.00%> (-14.83%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <0.00%> (-7.90%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.45% <0.00%> (-7.20%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `61.22% <0.00%> (-2.02%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.77% <0.00%> (-1.74%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...d97a519](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 71.38% -0.01%
==========================================
Files 585 586 +1
Lines 30949 30987 +38
Branches 3261 3267 +6
==========================================
+ Hits 22094 22119 +25
- Misses 8746 8758 +12
- Partials 109 110 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.98% <ø> (-0.11%)` | :arrow_down: |
| #javascript | `59.43% <84.61%> (+0.04%)` | :arrow_up: |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.45% <77.77%> (+0.82%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `88.23% <88.23%> (ø)` | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.15% <0.00%> (-0.66%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...dd933bc](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
+ Coverage 71.38% 71.58% +0.19%
==========================================
Files 585 184 -401
Lines 30949 18174 -12775
Branches 3261 0 -3261
==========================================
- Hits 22094 13009 -9085
+ Misses 8746 5165 -3581
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...perset-frontend/src/components/FilterBadgeIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyQmFkZ2VJY29uLmpzeA==) | | |
| [...src/dashboard/components/DeleteComponentButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0RlbGV0ZUNvbXBvbmVudEJ1dHRvbi5qc3g=) | | |
| [...erset-frontend/src/SqlLab/components/SaveQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS5qc3g=) | | |
| [...ashboard/components/gridComponents/new/NewTabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdUYWJzLmpzeA==) | | |
| [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | | |
| ... and [401 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...4dd33f7](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r436330655
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Button, Nav, Navbar, MenuItem } from 'react-bootstrap';
Review comment:
We may also want to decide whether to keep creating new UI components based on Bootstrap. To me, this seems like a great opportunity to migrate away from it.
What do you think, @rusackas @kristw ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 71.24% -0.15%
==========================================
Files 585 184 -401
Lines 30949 18096 -12853
Branches 3261 0 -3261
==========================================
- Hits 22094 12892 -9202
+ Misses 8746 5204 -3542
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.24% <ø> (-0.34%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <0.00%> (-2.34%)` | :arrow_down: |
| ... and [419 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...88d3f46](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 71.24% -0.15%
==========================================
Files 585 184 -401
Lines 30949 18096 -12853
Branches 3261 0 -3261
==========================================
- Hits 22094 12892 -9202
+ Misses 8746 5204 -3542
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.24% <ø> (-0.34%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <0.00%> (-2.34%)` | :arrow_down: |
| ... and [419 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...c1d48b5](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
+ Coverage 71.38% 71.51% +0.12%
==========================================
Files 585 184 -401
Lines 30949 18174 -12775
Branches 3261 0 -3261
==========================================
- Hits 22094 12997 -9097
+ Misses 8746 5177 -3569
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.51% <ø> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.38% <0.00%> (-0.22%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | | |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | | |
| ... and [404 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...4dd33f7](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `4.92%`.
> The diff coverage is `86.95%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 66.45% -4.93%
==========================================
Files 585 586 +1
Lines 30949 30920 -29
Branches 3261 3271 +10
==========================================
- Hits 22094 20549 -1545
- Misses 8746 10191 +1445
- Partials 109 180 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <86.95%> (+0.04%)` | :arrow_up: |
| #python | `71.43% <ø> (-0.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `87.50% <87.50%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [166 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...88d3f46](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
+ Coverage 71.38% 71.51% +0.12%
==========================================
Files 585 184 -401
Lines 30949 18174 -12775
Branches 3261 0 -3261
==========================================
- Hits 22094 12997 -9097
+ Misses 8746 5177 -3569
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.51% <ø> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.38% <0.00%> (-0.22%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...hboard/components/gridComponents/new/NewHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdIZWFkZXIuanN4) | | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | | |
| ... and [404 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...4dd33f7](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 71.38% -0.01%
==========================================
Files 585 586 +1
Lines 30949 30987 +38
Branches 3261 3267 +6
==========================================
+ Hits 22094 22119 +25
- Misses 8746 8758 +12
- Partials 109 110 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.98% <ø> (-0.11%)` | :arrow_down: |
| #javascript | `59.43% <84.61%> (+0.04%)` | :arrow_up: |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.45% <77.77%> (+0.82%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `88.23% <88.23%> (ø)` | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.15% <0.00%> (-0.66%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...dd933bc](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r434968611
##########
File path: superset-frontend/src/views/datasetList/DatasetList.tsx
##########
@@ -240,6 +240,28 @@ class DatasetList extends React.PureComponent<Props, State> {
},
];
+ menu = {
+ label: 'Data',
+ name: 'Data',
+ createButton: {
+ name: 'Dataset',
Review comment:
```suggestion
name: t('Dataset'),
```
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { t } from '@superset-ui/translation';
+import React from 'react';
+import { Button, Nav, Navbar, MenuItem } from 'react-bootstrap';
+
+interface Props {
+ createButton: { name: string; url: string | null };
+ canCreate: boolean;
+ label: string;
+ name: string;
+ childs: Array<{ label: string; name: string; url: string }>;
+}
+
+interface State {
+ selectedMenu: string;
+}
+
+class SubMenu extends React.PureComponent<Props, State> {
+ state: State = {
+ selectedMenu: this.props.childs[0] && this.props.childs[0].label,
+ };
+ handleClick = (item: string) => () => {
+ this.setState({ selectedMenu: item });
+ };
+
+ render() {
+ const { canCreate, childs, label, createButton } = this.props;
+
+ return (
+ <header className="top" id="secondary-menu">
+ <Navbar inverse fluid role="navigation">
+ <Navbar.Header>
+ <Navbar.Brand>{t('%s', `${label}`)}</Navbar.Brand>
Review comment:
This will have no effect on the translation, it'll just end up being whatever label is. The strings are collected at build time not run time, so you need the string literals.
##########
File path: superset-frontend/src/views/datasetList/DatasetList.tsx
##########
@@ -240,6 +240,28 @@ class DatasetList extends React.PureComponent<Props, State> {
},
];
+ menu = {
+ label: 'Data',
+ name: 'Data',
+ createButton: {
+ name: 'Dataset',
+ url: '/tablemodelview/add',
+ },
+ childs: [
+ {
+ name: 'Datasets',
+ label: 'Datasets',
Review comment:
```suggestion
label: t('Datasets'),
```
##########
File path: superset-frontend/src/views/datasetList/DatasetList.tsx
##########
@@ -240,6 +240,28 @@ class DatasetList extends React.PureComponent<Props, State> {
},
];
+ menu = {
+ label: 'Data',
+ name: 'Data',
+ createButton: {
+ name: 'Dataset',
+ url: '/tablemodelview/add',
+ },
+ childs: [
+ {
+ name: 'Datasets',
+ label: 'Datasets',
+ url: '/tablemodelview/list/?_flt_1_is_sqllab_view=y',
+ },
+ { name: 'Databases', label: 'Databases', url: '/databaseview/list/' },
+ {
+ name: 'Saved Queries',
+ label: 'Saved Queries',
Review comment:
```suggestion
label: t('Saved Queries'),
```
##########
File path: superset-frontend/src/views/datasetList/DatasetList.tsx
##########
@@ -240,6 +240,28 @@ class DatasetList extends React.PureComponent<Props, State> {
},
];
+ menu = {
+ label: 'Data',
+ name: 'Data',
+ createButton: {
+ name: 'Dataset',
+ url: '/tablemodelview/add',
+ },
+ childs: [
+ {
+ name: 'Datasets',
+ label: 'Datasets',
+ url: '/tablemodelview/list/?_flt_1_is_sqllab_view=y',
+ },
+ { name: 'Databases', label: 'Databases', url: '/databaseview/list/' },
Review comment:
```suggestion
{ name: 'Databases', label: t('Databases'), url: '/databaseview/list/' },
```
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { t } from '@superset-ui/translation';
+import React from 'react';
+import { Button, Nav, Navbar, MenuItem } from 'react-bootstrap';
+
+interface Props {
+ createButton: { name: string; url: string | null };
+ canCreate: boolean;
+ label: string;
+ name: string;
+ childs: Array<{ label: string; name: string; url: string }>;
+}
+
+interface State {
+ selectedMenu: string;
+}
+
+class SubMenu extends React.PureComponent<Props, State> {
+ state: State = {
+ selectedMenu: this.props.childs[0] && this.props.childs[0].label,
+ };
+ handleClick = (item: string) => () => {
+ this.setState({ selectedMenu: item });
+ };
+
+ render() {
+ const { canCreate, childs, label, createButton } = this.props;
+
+ return (
+ <header className="top" id="secondary-menu">
+ <Navbar inverse fluid role="navigation">
+ <Navbar.Header>
+ <Navbar.Brand>{t('%s', `${label}`)}</Navbar.Brand>
+ </Navbar.Header>
+ <Nav>
+ {childs &&
+ childs.map(child => (
+ <MenuItem
+ active={child.label === this.state.selectedMenu}
+ key={`${child.label}`}
+ eventKey={`${child.name}`}
+ href={child.url}
+ onClick={this.handleClick(child.label)}
+ >
+ {child.label}
+ </MenuItem>
+ ))}
+ </Nav>
+ {canCreate && (
+ <Nav className="navbar-right">
+ <Button href={`${createButton.url}`}>
+ <i className="fa fa-plus" /> {t('%s', `${createButton.name}`)}
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `1.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 69.75% -1.64%
==========================================
Files 585 184 -401
Lines 30949 18193 -12756
Branches 3261 0 -3261
==========================================
- Hits 22094 12691 -9403
+ Misses 8746 5502 -3244
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.75% <ø> (-1.82%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <0.00%> (-14.83%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| ... and [434 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...d97a519](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
+ Coverage 71.38% 71.58% +0.19%
==========================================
Files 585 184 -401
Lines 30949 18174 -12775
Branches 3261 0 -3261
==========================================
- Hits 22094 13009 -9085
+ Misses 8746 5165 -3581
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
| [...et-frontend/src/messageToasts/components/Toast.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC5qc3g=) | | |
| [superset-frontend/src/messageToasts/propShapes.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcHJvcFNoYXBlcy5qcw==) | | |
| [.../src/explore/components/controls/SliderControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TbGlkZXJDb250cm9sLmpzeA==) | | |
| ... and [401 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...21cbf89](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r436861431
##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
}
}
}
+
+#secondary-menu {
+ margin-top: -20px;
+ .navbar-header .navbar-brand {
+ font-weight: @font-weight-bold;
+ }
+ .navbar-right {
+ .btn-default {
+ text-transform: uppercase;
+ font-weight: 500;
+ font-size: @font-size-s;
+ background-color: @brand-primary;
+ border-radius: 4px;
+ color: @lightest;
+ margin: 8px 43px;
+ padding: 8px 51px 8px 43px;
+ border: none;
+ i {
+ padding: 4px @font-size-xs;
+ }
+ }
+ }
+ .navbar-nav {
+ li {
+ a {
+ font-size: @font-size-s;
+ padding: 8px;
+ margin: 8px;
+ color: #3d3d3d;
Review comment:
In cases of grays like this, there should be one pretty close to what you need... and we can adjust the global variable(s) to move closer to the new design as needed. Ping me if you want to discuss.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
+ Coverage 71.38% 71.40% +0.01%
==========================================
Files 585 586 +1
Lines 30949 30987 +38
Branches 3261 3267 +6
==========================================
+ Hits 22094 22125 +31
- Misses 8746 8753 +7
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.07% <ø> (-0.01%)` | :arrow_down: |
| #javascript | `59.43% <84.61%> (+0.04%)` | :arrow_up: |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.45% <77.77%> (+0.82%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `88.23% <88.23%> (ø)` | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.83% <0.00%> (+0.04%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...dd933bc](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 71.23% -0.16%
==========================================
Files 585 184 -401
Lines 30949 18092 -12857
Branches 3261 0 -3261
==========================================
- Hits 22094 12888 -9206
+ Misses 8746 5204 -3542
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.23% <ø> (-0.34%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <0.00%> (-2.34%)` | :arrow_down: |
| ... and [419 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...21cbf89](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r434943072
##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
}
}
}
+
+#secondary-menu {
+ margin-top: -20px;
+ .navbar-header .navbar-brand {
+ font-weight: @font-weight-bold;
+ }
+ .navbar-right {
+ .btn-default {
+ text-transform: uppercase;
+ font-weight: 500;
+ font-size: @font-size-s;
+ background-color: #20a7c9;
Review comment:
Can we make the blue "+DATASET" button `@brand-primary` for the time being.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `4.92%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 66.45% -4.93%
==========================================
Files 585 586 +1
Lines 30949 30921 -28
Branches 3261 3271 +10
==========================================
- Hits 22094 20550 -1544
- Misses 8746 10191 +1445
- Partials 109 180 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <87.50%> (+0.05%)` | :arrow_up: |
| #python | `71.43% <ø> (-0.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `88.23% <88.23%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [166 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...c1d48b5](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r435449180
##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
}
}
}
+
+#secondary-menu {
+ margin-top: -20px;
+ .navbar-header .navbar-brand {
+ font-weight: @font-weight-bold;
+ }
+ .navbar-right {
+ .btn-default {
+ text-transform: uppercase;
+ font-weight: 500;
+ font-size: @font-size-s;
+ background-color: @brand-primary;
+ border-radius: 4px;
+ color: @lightest;
+ margin: 8px 43px;
+ padding: 8px 51px 8px 43px;
+ border: none;
+ i {
+ padding: 4px @font-size-xs;
+ }
+ }
+ }
+ .navbar-nav {
+ li {
+ a {
+ font-size: @font-size-s;
+ padding: 8px;
+ margin: 8px;
+ color: #3d3d3d;
Review comment:
seconded: if there is any chance these colors will be reused it should be moved into a variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r436323451
##########
File path: superset-frontend/stylesheets/less/variables.less
##########
@@ -34,6 +34,8 @@
@gray-bg: #f5f5f5;
@gray-heading: #a3a3a3;
@menu-hover: #f2f3f5;
+@gray-light-hover: #eceef2;
+@gray-drak-heading: #3d3d3d;
Review comment:
typo? should we just reuse one of the greys above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `5.03%`.
> The diff coverage is `86.95%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 66.34% -5.04%
==========================================
Files 585 586 +1
Lines 30949 30920 -29
Branches 3261 3271 +10
==========================================
- Hits 22094 20515 -1579
- Misses 8746 10225 +1479
- Partials 109 180 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <86.95%> (+0.04%)` | :arrow_up: |
| #python | `71.24% <ø> (-0.34%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `87.50% <87.50%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...88d3f46](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `5.77%`.
> The diff coverage is `86.95%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 65.60% -5.78%
==========================================
Files 585 586 +1
Lines 30949 31058 +109
Branches 3261 3281 +20
==========================================
- Hits 22094 20377 -1717
- Misses 8746 10500 +1754
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <86.95%> (+0.01%)` | :arrow_up: |
| #python | `69.98% <ø> (-1.59%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.55% <85.71%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `87.50% <87.50%> (ø)` | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...d97a519](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org