[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #15580: update profiler tutorial

[GitBox <gi...@apache.org>]

ChaiBapchya commented on a change in pull request #15580: update profiler tutorial
URL: https://github.com/apache/incubator-mxnet/pull/15580#discussion_r305109130
 
 

 ##########
 File path: docs/tutorials/python/profiler.md
 ##########
 @@ -193,10 +193,10 @@ print(profiler.dumps())
 You can also dump the information collected by the profiler into a `json` file using the `profiler.dump()` function and view it in a browser.
 
 ```python
-profiler.dump()
+profiler.dump(finished=False)
 ```
 
-`dump()` creates a `json` file which can be viewed using a trace consumer like `chrome://tracing` in the Chrome browser. Here is a snapshot that shows the output of the profiling we did above.
+`dump()` creates a `json` file which can be viewed using a trace consumer like `chrome://tracing` in the Chrome browser. Here is a snapshot that shows the output of the profiling we did above. Note that setting the `finished` parameter to `False` will prevent the profiler from finishing dumpint to file. If you just use `profiler.dump()`, you will no longer be able to profile the remaining sections of your model. 
 
 Review comment:
   dumpint? dumping?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services