You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/05/11 01:14:52 UTC
[GitHub] nifi-minifi-cpp pull request #327: MINIFICPP-491: Disable logging for C api
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/327
MINIFICPP-491: Disable logging for C api
MINIFICPP-492: Resolve issues with resource claims and volatile repos in
C API
MINIFICPP-486: Begin forming async control functions
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp potato
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #327
----
commit 6e5b9a09c2be3f175f27ee333a84e96e1278cbd2
Author: Marc Parisi <ph...@...>
Date: 2018-05-08T16:43:30Z
MINIFICPP-491: Disable logging for C api
MINIFICPP-492: Resolve issues with resource claims and volatile repos in
C API
MINIFICPP-486: Begin forming async control functions
----
---
[GitHub] nifi-minifi-cpp issue #327: MINIFICPP-491: Disable logging for C api
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/327
https://travis-ci.org/phrocker/nifi-minifi-cpp/jobs/377542802 is a concerning test failure. I will investigate this.
---
[GitHub] nifi-minifi-cpp issue #327: MINIFICPP-491: Disable logging for C api
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/327
Thanks, clears that up. Will get this merged in.
---
[GitHub] nifi-minifi-cpp pull request #327: MINIFICPP-491: Disable logging for C api
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/327#discussion_r189354320
--- Diff: libminifi/include/capi/api.h ---
@@ -18,27 +18,32 @@
#ifndef LIBMINIFI_INCLUDE_CAPI_NANOFI_H_
#define LIBMINIFI_INCLUDE_CAPI_NANOFI_H_
+#include <stddef.h>
#include <stdint.h>
+#include "processors.h"
+
+int initialize_api();
#ifdef __cplusplus
extern "C" {
#endif
#define API_VERSION "0.01"
+
+void enable_logging();
+
/****
* ##################################################################
* BASE NIFI OPERATIONS
* ##################################################################
*/
-
/**
* NiFi Port struct
*/
typedef struct {
- char *pord_id;
-}nifi_port;
-
+ char *pord_id;
--- End diff --
-> port_id
---
[GitHub] nifi-minifi-cpp pull request #327: MINIFICPP-491: Disable logging for C api
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/327#discussion_r190681005
--- Diff: LibExample/CMakeLists.txt ---
@@ -59,3 +59,14 @@ else ()
target_link_libraries (generate_flow -Wl,--whole-archive minifi-http-curl -Wl,--no-whole-archive)
endif ()
+
+add_executable(monitor_directory monitor_directory.c)
+
+# Link against minifi, yaml-cpp, civetweb-cpp, uuid, openssl and rocksdb
--- End diff --
should we need to link against yaml? not sure I understand its function in the lib sense.
---
[GitHub] nifi-minifi-cpp pull request #327: MINIFICPP-491: Disable logging for C api
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/327
---
[GitHub] nifi-minifi-cpp pull request #327: MINIFICPP-491: Disable logging for C api
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/327#discussion_r189353771
--- Diff: blocks/comms.h ---
@@ -0,0 +1,47 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef BLOCKS_COMMS_H_
+#define BLOCKS_COMMS_H_
+
+#include <stdio.h>
+#include "capi/api.h"
+#include "capi/processors.h"
+
+#define SUCCESS 0x00
+#define FINISHE_EARLY 0x01
--- End diff --
-> FINISHED_EARLY
---