You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <br...@apache.org> on 2013/12/22 12:11:02 UTC

[VOTE] Release Commons Lang 3.2 based on RC1

Hello All,

We have fixed quite a few bugs and added some significant enhancements
since Commons Lang 3.1 was released, so I would like to release Commons
Lang 3.2.

Commons Lang 3.2 RC1 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 3964)

  Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/

  Details of changes since 3.1 are in the release notes:
    https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt

http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html

The tag is here:
  http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
1552978)

Site:
  http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
  (note some *relative* links are broken and the 1.2 directories are not
yet created - these will be OK once the site is deployed.
  Also note, that PMD shows a lot of warnings due to useless parenthesis.
We have decided to leave these in the code for readability.
  Findbugs has a few warnings, none of which we consider to be dangerous,
but as always: patches are welcome ;-)

Clirr Report (compared to 3.1):

http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
  (note that the Clirr report show 3 errors. This changes are considered to
be save for client code. More Information about this can be found in the
release notes)

RAT Report:

http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html

KEYS:
  http://www.apache.org/dist/commons/KEYS

  Please review the release candidate and vote.
  This vote will close no sooner that 72 hours from now, i.e. after
December 25 2013 at 12:30 CET

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

  Thanks!

  Benedikt

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Gary Gregory <ga...@gmail.com>.
Thank you for cutting the RC Benedikt.

While the Clirr breakage for FastDateFormat is documented as intentional
and 'safe' in the release notes, the first place I looked for information
is the Javadoc, IMO the same information from the release notes could be
duplicated in the Javadoc. The Javadoc is easier to find than the release
notes and Javadocs show up in search engines. The release notes file is not
reachable from the site (it should be IMO).

Version 3.2 is missing from the release history page.

I'll wait for RC2 to vote since you've hinted that it is coming. I would
send a [CANCEL][VOTE] reply to this thread to make that clear.

Happy Holidays!
Gary


On Sun, Dec 22, 2013 at 6:11 AM, Benedikt Ritter <br...@apache.org> wrote:

> Hello All,
>
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.1 was released, so I would like to release Commons
> Lang 3.2.
>
> Commons Lang 3.2 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
> 3964)
>
>   Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
>
>   Details of changes since 3.1 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
>
> The tag is here:
>
> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> 1552978)
>
> Site:
>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
>   (note some *relative* links are broken and the 1.2 directories are not
> yet created - these will be OK once the site is deployed.
>   Also note, that PMD shows a lot of warnings due to useless parenthesis.
> We have decided to leave these in the code for readability.
>   Findbugs has a few warnings, none of which we consider to be dangerous,
> but as always: patches are welcome ;-)
>
> Clirr Report (compared to 3.1):
>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
>   (note that the Clirr report show 3 errors. This changes are considered to
> be save for client code. More Information about this can be found in the
> release notes)
>
> RAT Report:
>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
>
> KEYS:
>   http://www.apache.org/dist/commons/KEYS
>
>   Please review the release candidate and vote.
>   This vote will close no sooner that 72 hours from now, i.e. after
> December 25 2013 at 12:30 CET
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!
>
>   Benedikt
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Matt Benson <gu...@gmail.com>.
For my $0.02 I'd say that if the Javadocs are usable it doesn't really
matter.  :|

Matt


On Mon, Dec 23, 2013 at 12:41 PM, Duncan Jones <du...@wortharead.com>wrote:

> On 23 Dec 2013 18:32, "Matt Benson" <gu...@gmail.com> wrote:
> >
> > Bene pointed out to me that he did build w/ Java 7; of course the target
> > setting in the POM is the reason the classfiles are Java 6 compatible,
> > which is the important thing in any case.
>
> Presumably that means the Javadocs have a Java 7 style? Is that a problem
> or do we produce the website Javadocs in a different process?
>
> Duncan
>
> >
> > Matt
> >
> >
> > On Mon, Dec 23, 2013 at 11:00 AM, Matt Benson <gu...@gmail.com>
> wrote:
> >
> > > - RAT report looks okay.
> > > - I successfully build the contents of the source artifacts with both
> Java
> > > 6 and Java 7
> > > - I successfully build the contents of the tag
> > > - britter code signing key is in
> > > https://dist.apache.org/repos/dist/release/commons/KEYS
> > > - All sigs and hashes check out
> > > - Binary jars appear to have been built using Java 6
> > > - All LICENSE and NOTICE files appear to be where they should
> > >
> > > +1 to release from me.
> > >
> > > Matt
> > >
> > >
> > > On Sun, Dec 22, 2013 at 5:11 AM, Benedikt Ritter <britter@apache.org
> >wrote:
> > >
> > >> Hello All,
> > >>
> > >> We have fixed quite a few bugs and added some significant enhancements
> > >> since Commons Lang 3.1 was released, so I would like to release
> Commons
> > >> Lang 3.2.
> > >>
> > >> Commons Lang 3.2 RC1 is available for review here:
> > >>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn
> revision
> > >> 3964)
> > >>
> > >>   Maven artifacts are here:
> > >>
> > >>
> > >>
>
> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
> > >>
> > >>   Details of changes since 3.1 are in the release notes:
> > >>
> https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> > >>
> > >>
> > >>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
> > >>
> > >> The tag is here:
> > >>
> > >>
> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> > >> 1552978)
> > >>
> > >> Site:
> > >>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
> > >>   (note some *relative* links are broken and the 1.2 directories are
> not
> > >> yet created - these will be OK once the site is deployed.
> > >>   Also note, that PMD shows a lot of warnings due to useless
> parenthesis.
> > >> We have decided to leave these in the code for readability.
> > >>   Findbugs has a few warnings, none of which we consider to be
> dangerous,
> > >> but as always: patches are welcome ;-)
> > >>
> > >> Clirr Report (compared to 3.1):
> > >>
> > >>
> > >>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
> > >>   (note that the Clirr report show 3 errors. This changes are
> considered
> > >> to
> > >> be save for client code. More Information about this can be found in
> the
> > >> release notes)
> > >>
> > >> RAT Report:
> > >>
> > >>
> > >>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
> > >>
> > >> KEYS:
> > >>   http://www.apache.org/dist/commons/KEYS
> > >>
> > >>   Please review the release candidate and vote.
> > >>   This vote will close no sooner that 72 hours from now, i.e. after
> > >> December 25 2013 at 12:30 CET
> > >>
> > >>   [ ] +1 Release these artifacts
> > >>   [ ] +0 OK, but...
> > >>   [ ] -0 OK, but really should fix...
> > >>   [ ] -1 I oppose this release because...
> > >>
> > >>   Thanks!
> > >>
> > >>   Benedikt
> > >>
> > >> --
> > >> http://people.apache.org/~britter/
> > >> http://www.systemoutprintln.de/
> > >> http://twitter.com/BenediktRitter
> > >> http://github.com/britter
> > >>
> > >
> > >
>

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Duncan Jones <du...@wortharead.com>.
On 23 Dec 2013 18:32, "Matt Benson" <gu...@gmail.com> wrote:
>
> Bene pointed out to me that he did build w/ Java 7; of course the target
> setting in the POM is the reason the classfiles are Java 6 compatible,
> which is the important thing in any case.

Presumably that means the Javadocs have a Java 7 style? Is that a problem
or do we produce the website Javadocs in a different process?

Duncan

>
> Matt
>
>
> On Mon, Dec 23, 2013 at 11:00 AM, Matt Benson <gu...@gmail.com>
wrote:
>
> > - RAT report looks okay.
> > - I successfully build the contents of the source artifacts with both
Java
> > 6 and Java 7
> > - I successfully build the contents of the tag
> > - britter code signing key is in
> > https://dist.apache.org/repos/dist/release/commons/KEYS
> > - All sigs and hashes check out
> > - Binary jars appear to have been built using Java 6
> > - All LICENSE and NOTICE files appear to be where they should
> >
> > +1 to release from me.
> >
> > Matt
> >
> >
> > On Sun, Dec 22, 2013 at 5:11 AM, Benedikt Ritter <britter@apache.org
>wrote:
> >
> >> Hello All,
> >>
> >> We have fixed quite a few bugs and added some significant enhancements
> >> since Commons Lang 3.1 was released, so I would like to release Commons
> >> Lang 3.2.
> >>
> >> Commons Lang 3.2 RC1 is available for review here:
> >>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
> >> 3964)
> >>
> >>   Maven artifacts are here:
> >>
> >>
> >>
https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
> >>
> >>   Details of changes since 3.1 are in the release notes:
> >>
https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> >>
> >>
> >>
http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
> >>
> >> The tag is here:
> >>
> >>
http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> >> 1552978)
> >>
> >> Site:
> >>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
> >>   (note some *relative* links are broken and the 1.2 directories are
not
> >> yet created - these will be OK once the site is deployed.
> >>   Also note, that PMD shows a lot of warnings due to useless
parenthesis.
> >> We have decided to leave these in the code for readability.
> >>   Findbugs has a few warnings, none of which we consider to be
dangerous,
> >> but as always: patches are welcome ;-)
> >>
> >> Clirr Report (compared to 3.1):
> >>
> >>
> >>
http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
> >>   (note that the Clirr report show 3 errors. This changes are
considered
> >> to
> >> be save for client code. More Information about this can be found in
the
> >> release notes)
> >>
> >> RAT Report:
> >>
> >>
> >>
http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
> >>
> >> KEYS:
> >>   http://www.apache.org/dist/commons/KEYS
> >>
> >>   Please review the release candidate and vote.
> >>   This vote will close no sooner that 72 hours from now, i.e. after
> >> December 25 2013 at 12:30 CET
> >>
> >>   [ ] +1 Release these artifacts
> >>   [ ] +0 OK, but...
> >>   [ ] -0 OK, but really should fix...
> >>   [ ] -1 I oppose this release because...
> >>
> >>   Thanks!
> >>
> >>   Benedikt
> >>
> >> --
> >> http://people.apache.org/~britter/
> >> http://www.systemoutprintln.de/
> >> http://twitter.com/BenediktRitter
> >> http://github.com/britter
> >>
> >
> >

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Matt Benson <gu...@gmail.com>.
Bene pointed out to me that he did build w/ Java 7; of course the target
setting in the POM is the reason the classfiles are Java 6 compatible,
which is the important thing in any case.

Matt


On Mon, Dec 23, 2013 at 11:00 AM, Matt Benson <gu...@gmail.com> wrote:

> - RAT report looks okay.
> - I successfully build the contents of the source artifacts with both Java
> 6 and Java 7
> - I successfully build the contents of the tag
> - britter code signing key is in
> https://dist.apache.org/repos/dist/release/commons/KEYS
> - All sigs and hashes check out
> - Binary jars appear to have been built using Java 6
> - All LICENSE and NOTICE files appear to be where they should
>
> +1 to release from me.
>
> Matt
>
>
> On Sun, Dec 22, 2013 at 5:11 AM, Benedikt Ritter <br...@apache.org>wrote:
>
>> Hello All,
>>
>> We have fixed quite a few bugs and added some significant enhancements
>> since Commons Lang 3.1 was released, so I would like to release Commons
>> Lang 3.2.
>>
>> Commons Lang 3.2 RC1 is available for review here:
>>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
>> 3964)
>>
>>   Maven artifacts are here:
>>
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
>>
>>   Details of changes since 3.1 are in the release notes:
>>     https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>>
>>
>> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
>>
>> The tag is here:
>>
>> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
>> 1552978)
>>
>> Site:
>>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
>>   (note some *relative* links are broken and the 1.2 directories are not
>> yet created - these will be OK once the site is deployed.
>>   Also note, that PMD shows a lot of warnings due to useless parenthesis.
>> We have decided to leave these in the code for readability.
>>   Findbugs has a few warnings, none of which we consider to be dangerous,
>> but as always: patches are welcome ;-)
>>
>> Clirr Report (compared to 3.1):
>>
>>
>> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
>>   (note that the Clirr report show 3 errors. This changes are considered
>> to
>> be save for client code. More Information about this can be found in the
>> release notes)
>>
>> RAT Report:
>>
>>
>> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
>>
>> KEYS:
>>   http://www.apache.org/dist/commons/KEYS
>>
>>   Please review the release candidate and vote.
>>   This vote will close no sooner that 72 hours from now, i.e. after
>> December 25 2013 at 12:30 CET
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>>   Thanks!
>>
>>   Benedikt
>>
>> --
>> http://people.apache.org/~britter/
>> http://www.systemoutprintln.de/
>> http://twitter.com/BenediktRitter
>> http://github.com/britter
>>
>
>

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Matt Benson <gu...@gmail.com>.
- RAT report looks okay.
- I successfully build the contents of the source artifacts with both Java
6 and Java 7
- I successfully build the contents of the tag
- britter code signing key is in
https://dist.apache.org/repos/dist/release/commons/KEYS
- All sigs and hashes check out
- Binary jars appear to have been built using Java 6
- All LICENSE and NOTICE files appear to be where they should

+1 to release from me.

Matt


On Sun, Dec 22, 2013 at 5:11 AM, Benedikt Ritter <br...@apache.org> wrote:

> Hello All,
>
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.1 was released, so I would like to release Commons
> Lang 3.2.
>
> Commons Lang 3.2 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
> 3964)
>
>   Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
>
>   Details of changes since 3.1 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
>
> The tag is here:
>
> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> 1552978)
>
> Site:
>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
>   (note some *relative* links are broken and the 1.2 directories are not
> yet created - these will be OK once the site is deployed.
>   Also note, that PMD shows a lot of warnings due to useless parenthesis.
> We have decided to leave these in the code for readability.
>   Findbugs has a few warnings, none of which we consider to be dangerous,
> but as always: patches are welcome ;-)
>
> Clirr Report (compared to 3.1):
>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
>   (note that the Clirr report show 3 errors. This changes are considered to
> be save for client code. More Information about this can be found in the
> release notes)
>
> RAT Report:
>
>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
>
> KEYS:
>   http://www.apache.org/dist/commons/KEYS
>
>   Please review the release candidate and vote.
>   This vote will close no sooner that 72 hours from now, i.e. after
> December 25 2013 at 12:30 CET
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!
>
>   Benedikt
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Benedikt Ritter <br...@apache.org>.
Hi Jörg,


2013/12/23 Jörg Schaible <jo...@gmx.de>

>
> Hi,
>
> I don't know what it is, but for me the download of
>
> https://dist.apache.org/repos/dist/dev/commons/lang/source/commons-lang3-3.2-src.tar.gzalways stops at 71% ... anyone else ?!?
>

Don't know, works on my machine. I'm using Safari on Mac OS 10.9.1


>
> - Jörg
>
> Benedikt Ritter wrote:
>
> > Hello All,
> >
> > We have fixed quite a few bugs and added some significant enhancements
> > since Commons Lang 3.1 was released, so I would like to release Commons
> > Lang 3.2.
> >
> > Commons Lang 3.2 RC1 is available for review here:
> >     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
> >     3964)
> >
> >   Maven artifacts are here:
> >
> >
>
> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
> >
> >   Details of changes since 3.1 are in the release notes:
> >
> https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> >
> >
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
> >
> > The tag is here:
> >
> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> > 1552978)
> >
> > Site:
> >   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
> >   (note some *relative* links are broken and the 1.2 directories are not
> > yet created - these will be OK once the site is deployed.
> >   Also note, that PMD shows a lot of warnings due to useless parenthesis.
> > We have decided to leave these in the code for readability.
> >   Findbugs has a few warnings, none of which we consider to be dangerous,
> > but as always: patches are welcome ;-)
> >
> > Clirr Report (compared to 3.1):
> >
> >
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
> >   (note that the Clirr report show 3 errors. This changes are considered
> >   to
> > be save for client code. More Information about this can be found in the
> > release notes)
> >
> > RAT Report:
> >
> >
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
> >
> > KEYS:
> >   http://www.apache.org/dist/commons/KEYS
> >
> >   Please review the release candidate and vote.
> >   This vote will close no sooner that 72 hours from now, i.e. after
> > December 25 2013 at 12:30 CET
> >
> >   [ ] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
> >
> >   Thanks!
> >
> >   Benedikt
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Jörg Schaible <jo...@gmx.de>.
Hi,

I don't know what it is, but for me the download of 
https://dist.apache.org/repos/dist/dev/commons/lang/source/commons-lang3-3.2-src.tar.gz always stops at 71% ... anyone else ?!?

- Jörg

Benedikt Ritter wrote:

> Hello All,
> 
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.1 was released, so I would like to release Commons
> Lang 3.2.
> 
> Commons Lang 3.2 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
>     3964)
> 
>   Maven artifacts are here:
> 
> 
https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
> 
>   Details of changes since 3.1 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> 
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
> 
> The tag is here:
>   
http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> 1552978)
> 
> Site:
>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
>   (note some *relative* links are broken and the 1.2 directories are not
> yet created - these will be OK once the site is deployed.
>   Also note, that PMD shows a lot of warnings due to useless parenthesis.
> We have decided to leave these in the code for readability.
>   Findbugs has a few warnings, none of which we consider to be dangerous,
> but as always: patches are welcome ;-)
> 
> Clirr Report (compared to 3.1):
> 
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
>   (note that the Clirr report show 3 errors. This changes are considered
>   to
> be save for client code. More Information about this can be found in the
> release notes)
> 
> RAT Report:
> 
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
> 
> KEYS:
>   http://www.apache.org/dist/commons/KEYS
> 
>   Please review the release candidate and vote.
>   This vote will close no sooner that 72 hours from now, i.e. after
> December 25 2013 at 12:30 CET
> 
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
> 
>   Thanks!
> 
>   Benedikt
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Benedikt Ritter <br...@apache.org>.
2013/12/23 Oliver Heger <ol...@oliver-heger.de>

> Am 23.12.2013 10:26, schrieb Benedikt Ritter:
> > Hello Oilver,
> >
> > thanks for your review and the suggestions.
> >
> >
> > 2013/12/22 Oliver Heger <ol...@oliver-heger.de>
> >
> >> Hi Benedikt,
> >>
> >> the release notes mention that Lang 3.0 and onwards requires Java 5,
> >> while the 3.2 release actually needs Java 6. I think this has to be
> >> explicitly stated.
> >>
> >
> > Oh, yes! Would probably be better if this was more explicit. But if there
> > are no other urgent problems with the RC, I'd like to spare myself the
> > trouble of cutting an new release just for this.
> As this is a significant change compared to the previous version, I
> would prefer having this mentioned in the release notes. Also on the
> site, under "Documentation" it is stated "The current stable release 3.2
> [Java 5.0+]".
>
> >
> >
> >>
> >> Otherwise, everything looks good. Build runs successful with Java 1.7 on
> >> Windows 8.1. Artifacts and site look good; the release notes give a good
> >> explanation for the errors reported by Clirr.
> >>
> >> One very minor point: The built-by header in the generated manifest
> >> files does not contain your Apache ID. You can achieve this by adding
> >> the property -Duser.name=<apacheID> when building the distributions with
> >> Maven.
> >>
> >
> > Didn't know that! I've updated our releasing manual with this information
> > in SVN (for some reason build bot doesn't publish it at the moment, I'll
> > try again later today).
> Great. Thanks.
>
> >
> > What is your vote for this RC? Do I get your +1 or would you rather see a
> > RC2?
> Well, I am more -0 because of the release notes. But I think you have
> enough +1s.
>

No, currently only you and Matt have voted. And Matt already told me via
IRC that he would like to see the release notes changed as well. I'm
hesitant to cancel the vote right now. I'm hoping to get some more
feedback, since this is my first RC. But I think I'll roll out a RC2 after
christmas (which will probably stop anybody who indented to review this RC
:-)

Thanks for spotting this!

Benedikt


>
> Oliver
>
> >
> > Benedikt
> >
> >
> >>
> >> Oliver
> >>
> >> Am 22.12.2013 12:11, schrieb Benedikt Ritter:
> >>> Hello All,
> >>>
> >>> We have fixed quite a few bugs and added some significant enhancements
> >>> since Commons Lang 3.1 was released, so I would like to release Commons
> >>> Lang 3.2.
> >>>
> >>> Commons Lang 3.2 RC1 is available for review here:
> >>>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
> >> 3964)
> >>>
> >>>   Maven artifacts are here:
> >>>
> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
> >>>
> >>>   Details of changes since 3.1 are in the release notes:
> >>>
> >> https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> >>>
> >>>
> >>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
> >>>
> >>> The tag is here:
> >>>
> >>
> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> >>> 1552978)
> >>>
> >>> Site:
> >>>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
> >>>   (note some *relative* links are broken and the 1.2 directories are
> not
> >>> yet created - these will be OK once the site is deployed.
> >>>   Also note, that PMD shows a lot of warnings due to useless
> parenthesis.
> >>> We have decided to leave these in the code for readability.
> >>>   Findbugs has a few warnings, none of which we consider to be
> dangerous,
> >>> but as always: patches are welcome ;-)
> >>>
> >>> Clirr Report (compared to 3.1):
> >>>
> >>>
> >>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
> >>>   (note that the Clirr report show 3 errors. This changes are
> considered
> >> to
> >>> be save for client code. More Information about this can be found in
> the
> >>> release notes)
> >>>
> >>> RAT Report:
> >>>
> >>>
> >>
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
> >>>
> >>> KEYS:
> >>>   http://www.apache.org/dist/commons/KEYS
> >>>
> >>>   Please review the release candidate and vote.
> >>>   This vote will close no sooner that 72 hours from now, i.e. after
> >>> December 25 2013 at 12:30 CET
> >>>
> >>>   [ ] +1 Release these artifacts
> >>>   [ ] +0 OK, but...
> >>>   [ ] -0 OK, but really should fix...
> >>>   [ ] -1 I oppose this release because...
> >>>
> >>>   Thanks!
> >>>
> >>>   Benedikt
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Oliver Heger <ol...@oliver-heger.de>.
Am 23.12.2013 10:26, schrieb Benedikt Ritter:
> Hello Oilver,
> 
> thanks for your review and the suggestions.
> 
> 
> 2013/12/22 Oliver Heger <ol...@oliver-heger.de>
> 
>> Hi Benedikt,
>>
>> the release notes mention that Lang 3.0 and onwards requires Java 5,
>> while the 3.2 release actually needs Java 6. I think this has to be
>> explicitly stated.
>>
> 
> Oh, yes! Would probably be better if this was more explicit. But if there
> are no other urgent problems with the RC, I'd like to spare myself the
> trouble of cutting an new release just for this.
As this is a significant change compared to the previous version, I
would prefer having this mentioned in the release notes. Also on the
site, under "Documentation" it is stated "The current stable release 3.2
[Java 5.0+]".

> 
> 
>>
>> Otherwise, everything looks good. Build runs successful with Java 1.7 on
>> Windows 8.1. Artifacts and site look good; the release notes give a good
>> explanation for the errors reported by Clirr.
>>
>> One very minor point: The built-by header in the generated manifest
>> files does not contain your Apache ID. You can achieve this by adding
>> the property -Duser.name=<apacheID> when building the distributions with
>> Maven.
>>
> 
> Didn't know that! I've updated our releasing manual with this information
> in SVN (for some reason build bot doesn't publish it at the moment, I'll
> try again later today).
Great. Thanks.

> 
> What is your vote for this RC? Do I get your +1 or would you rather see a
> RC2?
Well, I am more -0 because of the release notes. But I think you have
enough +1s.

Oliver

> 
> Benedikt
> 
> 
>>
>> Oliver
>>
>> Am 22.12.2013 12:11, schrieb Benedikt Ritter:
>>> Hello All,
>>>
>>> We have fixed quite a few bugs and added some significant enhancements
>>> since Commons Lang 3.1 was released, so I would like to release Commons
>>> Lang 3.2.
>>>
>>> Commons Lang 3.2 RC1 is available for review here:
>>>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
>> 3964)
>>>
>>>   Maven artifacts are here:
>>>
>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
>>>
>>>   Details of changes since 3.1 are in the release notes:
>>>
>> https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>>>
>>>
>> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
>>>
>>> The tag is here:
>>>
>> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
>>> 1552978)
>>>
>>> Site:
>>>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
>>>   (note some *relative* links are broken and the 1.2 directories are not
>>> yet created - these will be OK once the site is deployed.
>>>   Also note, that PMD shows a lot of warnings due to useless parenthesis.
>>> We have decided to leave these in the code for readability.
>>>   Findbugs has a few warnings, none of which we consider to be dangerous,
>>> but as always: patches are welcome ;-)
>>>
>>> Clirr Report (compared to 3.1):
>>>
>>>
>> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
>>>   (note that the Clirr report show 3 errors. This changes are considered
>> to
>>> be save for client code. More Information about this can be found in the
>>> release notes)
>>>
>>> RAT Report:
>>>
>>>
>> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
>>>
>>> KEYS:
>>>   http://www.apache.org/dist/commons/KEYS
>>>
>>>   Please review the release candidate and vote.
>>>   This vote will close no sooner that 72 hours from now, i.e. after
>>> December 25 2013 at 12:30 CET
>>>
>>>   [ ] +1 Release these artifacts
>>>   [ ] +0 OK, but...
>>>   [ ] -0 OK, but really should fix...
>>>   [ ] -1 I oppose this release because...
>>>
>>>   Thanks!
>>>
>>>   Benedikt
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Benedikt Ritter <br...@apache.org>.
Hello Oilver,

thanks for your review and the suggestions.


2013/12/22 Oliver Heger <ol...@oliver-heger.de>

> Hi Benedikt,
>
> the release notes mention that Lang 3.0 and onwards requires Java 5,
> while the 3.2 release actually needs Java 6. I think this has to be
> explicitly stated.
>

Oh, yes! Would probably be better if this was more explicit. But if there
are no other urgent problems with the RC, I'd like to spare myself the
trouble of cutting an new release just for this.


>
> Otherwise, everything looks good. Build runs successful with Java 1.7 on
> Windows 8.1. Artifacts and site look good; the release notes give a good
> explanation for the errors reported by Clirr.
>
> One very minor point: The built-by header in the generated manifest
> files does not contain your Apache ID. You can achieve this by adding
> the property -Duser.name=<apacheID> when building the distributions with
> Maven.
>

Didn't know that! I've updated our releasing manual with this information
in SVN (for some reason build bot doesn't publish it at the moment, I'll
try again later today).

What is your vote for this RC? Do I get your +1 or would you rather see a
RC2?

Benedikt


>
> Oliver
>
> Am 22.12.2013 12:11, schrieb Benedikt Ritter:
> > Hello All,
> >
> > We have fixed quite a few bugs and added some significant enhancements
> > since Commons Lang 3.1 was released, so I would like to release Commons
> > Lang 3.2.
> >
> > Commons Lang 3.2 RC1 is available for review here:
> >     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
> 3964)
> >
> >   Maven artifacts are here:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
> >
> >   Details of changes since 3.1 are in the release notes:
> >
> https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> >
> >
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
> >
> > The tag is here:
> >
> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> > 1552978)
> >
> > Site:
> >   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
> >   (note some *relative* links are broken and the 1.2 directories are not
> > yet created - these will be OK once the site is deployed.
> >   Also note, that PMD shows a lot of warnings due to useless parenthesis.
> > We have decided to leave these in the code for readability.
> >   Findbugs has a few warnings, none of which we consider to be dangerous,
> > but as always: patches are welcome ;-)
> >
> > Clirr Report (compared to 3.1):
> >
> >
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
> >   (note that the Clirr report show 3 errors. This changes are considered
> to
> > be save for client code. More Information about this can be found in the
> > release notes)
> >
> > RAT Report:
> >
> >
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
> >
> > KEYS:
> >   http://www.apache.org/dist/commons/KEYS
> >
> >   Please review the release candidate and vote.
> >   This vote will close no sooner that 72 hours from now, i.e. after
> > December 25 2013 at 12:30 CET
> >
> >   [ ] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
> >
> >   Thanks!
> >
> >   Benedikt
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [VOTE] Release Commons Lang 3.2 based on RC1

Posted by Oliver Heger <ol...@oliver-heger.de>.
Hi Benedikt,

the release notes mention that Lang 3.0 and onwards requires Java 5,
while the 3.2 release actually needs Java 6. I think this has to be
explicitly stated.

Otherwise, everything looks good. Build runs successful with Java 1.7 on
Windows 8.1. Artifacts and site look good; the release notes give a good
explanation for the errors reported by Clirr.

One very minor point: The built-by header in the generated manifest
files does not contain your Apache ID. You can achieve this by adding
the property -Duser.name=<apacheID> when building the distributions with
Maven.

Oliver

Am 22.12.2013 12:11, schrieb Benedikt Ritter:
> Hello All,
> 
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.1 was released, so I would like to release Commons
> Lang 3.2.
> 
> Commons Lang 3.2 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 3964)
> 
>   Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-014/org/apache/commons/commons-lang3/3.2/
> 
>   Details of changes since 3.1 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> 
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/changes-report.html
> 
> The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_2_RC1/(svn
> 1552978)
> 
> Site:
>   http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/
>   (note some *relative* links are broken and the 1.2 directories are not
> yet created - these will be OK once the site is deployed.
>   Also note, that PMD shows a lot of warnings due to useless parenthesis.
> We have decided to leave these in the code for readability.
>   Findbugs has a few warnings, none of which we consider to be dangerous,
> but as always: patches are welcome ;-)
> 
> Clirr Report (compared to 3.1):
> 
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/clirr-report.html
>   (note that the Clirr report show 3 errors. This changes are considered to
> be save for client code. More Information about this can be found in the
> release notes)
> 
> RAT Report:
> 
> http://people.apache.org/~britter/commons-lang3/3.2-RC1/site/rat-report.html
> 
> KEYS:
>   http://www.apache.org/dist/commons/KEYS
> 
>   Please review the release candidate and vote.
>   This vote will close no sooner that 72 hours from now, i.e. after
> December 25 2013 at 12:30 CET
> 
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
> 
>   Thanks!
> 
>   Benedikt
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org