You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <np...@gmail.com> on 2018/07/25 14:46:43 UTC

Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68042/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2160
    https://issues.apache.org/jira/browse/RANGER-2160


Repository: ranger


Description
-------

'Email Address' search is not working properly along with other filter in user listing page,userRoles filters also needs to be improved.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 7f5eab7 
  security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 35b9d0a 
  security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 6f28e7b 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java 7df0640 
  security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 79f347d 
  security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java e564e28 


Diff: https://reviews.apache.org/r/68042/diff/1/


Testing
-------

Tested if email id filter & user roles along with other filters are working properly.


Thanks,

Nikhil P


Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68042/#review206496
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java
Lines 175 (patched)
<https://reviews.apache.org/r/68042/#comment289474>

    This could be "final", and maybe Set, as only the "contains" method is used.


- Zsombor Gegesy


On July 25, 2018, 2:46 p.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68042/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 2:46 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2160
>     https://issues.apache.org/jira/browse/RANGER-2160
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 'Email Address' search is not working properly along with other filter in user listing page,userRoles filters also needs to be improved.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 7f5eab7 
>   security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 35b9d0a 
>   security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 6f28e7b 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java 7df0640 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 79f347d 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java e564e28 
> 
> 
> Diff: https://reviews.apache.org/r/68042/diff/1/
> 
> 
> Testing
> -------
> 
> Tested if email id filter & user roles along with other filters are working properly.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68042/#review206540
-----------------------------------------------------------


Ship it!




Ship It!

- Zsombor Gegesy


On July 27, 2018, 7:32 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68042/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 7:32 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2160
>     https://issues.apache.org/jira/browse/RANGER-2160
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 'Email Address' search is not working properly along with other filter in user listing page,userRoles filters also needs to be improved.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ea60e99 
>   security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 35b9d0a 
>   security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 6f28e7b 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java 7df0640 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 79f347d 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java e564e28 
> 
> 
> Diff: https://reviews.apache.org/r/68042/diff/2/
> 
> 
> Testing
> -------
> 
> Tested if email id filter & user roles along with other filters are working properly.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68042/#review206586
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On July 27, 2018, 7:32 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68042/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 7:32 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2160
>     https://issues.apache.org/jira/browse/RANGER-2160
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 'Email Address' search is not working properly along with other filter in user listing page,userRoles filters also needs to be improved.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ea60e99 
>   security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 35b9d0a 
>   security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 6f28e7b 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java 7df0640 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 79f347d 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java e564e28 
> 
> 
> Diff: https://reviews.apache.org/r/68042/diff/2/
> 
> 
> Testing
> -------
> 
> Tested if email id filter & user roles along with other filters are working properly.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

Posted by Nikhil P <np...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68042/
-----------------------------------------------------------

(Updated July 27, 2018, 1:02 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2160
    https://issues.apache.org/jira/browse/RANGER-2160


Repository: ranger


Description
-------

'Email Address' search is not working properly along with other filter in user listing page,userRoles filters also needs to be improved.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ea60e99 
  security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 35b9d0a 
  security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 6f28e7b 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java 7df0640 
  security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 79f347d 
  security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java e564e28 


Diff: https://reviews.apache.org/r/68042/diff/2/

Changes: https://reviews.apache.org/r/68042/diff/1-2/


Testing
-------

Tested if email id filter & user roles along with other filters are working properly.


Thanks,

Nikhil P