You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Michael Sokolov (Jira)" <ji...@apache.org> on 2020/06/12 13:17:00 UTC
[jira] [Commented] (SOLR-14534) Investigate cleaning up any
remaining warnings in 8x
[ https://issues.apache.org/jira/browse/SOLR-14534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134213#comment-17134213 ]
Michael Sokolov commented on SOLR-14534:
----------------------------------------
I decided not to backport LUCENE-9394, cleaning up warnings in lucene/. I was concerned mostly about the change of raw {{Map}} to {{Map<Object, Object>}} in {{ValueSource}} being not backwards-compatible. Maybe it is not such a big change, but consumers would potentially have to add casts.
> Investigate cleaning up any remaining warnings in 8x
> ----------------------------------------------------
>
> Key: SOLR-14534
> URL: https://issues.apache.org/jira/browse/SOLR-14534
> Project: Solr
> Issue Type: Sub-task
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> There will be some divergence between master and 8x. The current pattern is
> 1> clean up warnings in master
> 2> backport to 8x and insure all tests etc run.
> Conspicuously missing is compiling under 8x and insuring that there are no warnings in the cleaned code.
> I'm not sure I really will do this if it turns out there are a lot of them. It's good enough that master is (and stay) clean IMO. OTOH, if it only takes a short time. Won't be able to tell until we get code clean.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org