[jira] [Commented] (METAMODEL-1099) Externalize DataContext factory from properties from MetaModel-spring to MetaModel-full

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METAMODEL-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363866#comment-15363866 ] 

ASF GitHub Bot commented on METAMODEL-1099:
-------------------------------------------

Github user LosD commented on the issue:

    https://github.com/apache/metamodel/pull/113
  
    Overall idea is brilliant (of course I instantly think "Hey, OSGi ServiceFactory!", but this is close enough :smile:).
    
    I'm _very_ happy nothing ended up in MetaModel-full as initially suggested in METAMODEL-1099, as that is something I think we should deprecate because of all the dependency issues it instantly brings to anyone using it. This might even make MM-full less interesting.


> Externalize DataContext factory from properties from MetaModel-spring to MetaModel-full
> ---------------------------------------------------------------------------------------
>
>                 Key: METAMODEL-1099
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-1099
>             Project: Apache MetaModel
>          Issue Type: New Feature
>    Affects Versions: 4.5.3
>            Reporter: Kasper Sørensen
>            Assignee: Kasper Sørensen
>             Fix For: 4.5.4, 5.0.0
>
>
> While working on the RESTful web application / API for MetaModel [1] I encountered that I was starting to re-invent the work that has already been done in MetaModel-spring to convert a set of properties (in that case in the form of a Spring bean) into instructions for constructing a DataContext.
> I think we need to have this functionality externalized for more general reuse. I was also just now looking into integrating Apache MetaModel with Apache Calcite and see that their APIs take a Map<String,Object> to create their equivalent of a DataContext. So once again I had the need to reuse this functionality. I can think of even more scenarios ...
> So my suggestion with this issue is to make an class called DataContextPropertiesLoader (although I am open to better naming suggestions). It would be serializable and would hold the properties need to construct any datacontext. This class could then be leveraged by MetaModel-spring, by DataContextFactory and other projects.
> [1] https://github.com/apache/metamodel/pull/110



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)