[jira] [Commented] (WW-4674) StrutsPrepareAndExecuteFilter should check for response commited status

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496467#comment-15496467 ] 

ASF subversion and git services commented on WW-4674:
-----------------------------------------------------

Commit 459e198022e8b96e9c3d5f97b1d4c428794ffb96 in struts's branch refs/heads/master from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=459e198 ]

WW-4674 Uses the same logic as in Dispatcher to control handling exception


> StrutsPrepareAndExecuteFilter  should check for response commited status
> ------------------------------------------------------------------------
>
>                 Key: WW-4674
>                 URL: https://issues.apache.org/jira/browse/WW-4674
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.3.30
>            Reporter: Mirek Hankus
>             Fix For: 2.3.31, 2.5.3
>
>
> In StrutsPrepareAndExecuteFilter in doFilter method there is a code fragment
> {code}
> ActionMapping mapping = this.prepare.findActionMapping(request, response, true);
> if(mapping == null) {
>     boolean handled = this.execute.executeStaticResourceRequest(request, response);
>     if(!handled) {
>            chain.doFilter(request, response);
>     }
> } else {
>     this.execute.executeAction(request, response, mapping);
> }
> {code}
> Problem is that {{this.prepare.findActionMapping(request, response, true)}} can commit response (in case of exception), but filter continues with execution of chain, in my case causing problems up in the chain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)