You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/07/23 03:05:50 UTC
[jira] Created: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Migrate logical optimization rule: OpLimitOptimizer
---------------------------------------------------
Key: PIG-1514
URL: https://issues.apache.org/jira/browse/PIG-1514
Project: Pig
Issue Type: Sub-task
Components: impl
Affects Versions: 0.7.0
Reporter: Daniel Dai
Assignee: Xuefu Zhang
Fix For: 0.8.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1514:
----------------------------
Status: Open (was: Patch Available)
> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
> Key: PIG-1514
> URL: https://issues.apache.org/jira/browse/PIG-1514
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1514-0.patch, jira-1514-1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901279#action_12901279 ]
Daniel Dai commented on PIG-1514:
---------------------------------
One minor correction, adding:
{code}
currentPlan.remove(limit);
{code}
to OptimizeLimit:197
> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
> Key: PIG-1514
> URL: https://issues.apache.org/jira/browse/PIG-1514
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1514-0.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1514:
-----------------------------
Attachment: jira-1514-0.patch
> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
> Key: PIG-1514
> URL: https://issues.apache.org/jira/browse/PIG-1514
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1514-0.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900376#action_12900376 ]
Richard Ding commented on PIG-1514:
-----------------------------------
Patch looks good. A couple of comments:
* It would be better to refactor the graph manipulation code into a helper class so that the graph transformation routines (such as swap, insert, remove, replace, ...) can be shared by all rules.
* Please remove tabs from the file.
> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
> Key: PIG-1514
> URL: https://issues.apache.org/jira/browse/PIG-1514
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1514-0.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1514:
----------------------------
Attachment: jira-1514-1.patch
Regenerate patch to fix unit test fail.
> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
> Key: PIG-1514
> URL: https://issues.apache.org/jira/browse/PIG-1514
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1514-0.patch, jira-1514-1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1514:
-----------------------------
Status: Patch Available (was: Open)
> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
> Key: PIG-1514
> URL: https://issues.apache.org/jira/browse/PIG-1514
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1514-0.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1514:
----------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
Did a combined test-patch with PIG-1497:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 80 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 443 release audit warnings (more than the trunk's current 433 warnings).
All new source code has license header except for test benchmarks (new-optlimitplan*.dot)
Patch committed. Thanks Xuefu!
> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
> Key: PIG-1514
> URL: https://issues.apache.org/jira/browse/PIG-1514
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1514-0.patch, jira-1514-1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1514) Migrate logical optimization rule:
OpLimitOptimizer
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1514:
----------------------------
Status: Patch Available (was: Open)
> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
> Key: PIG-1514
> URL: https://issues.apache.org/jira/browse/PIG-1514
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1514-0.patch, jira-1514-1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.