You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2024/01/06 06:27:34 UTC
[I] Add DistSQLSegment [shardingsphere]
RaigorJiang opened a new issue, #29665:
URL: https://github.com/apache/shardingsphere/issues/29665
There are many DistSQL-related segment classes now, and they directly inherit interface `ASTNode`, which is inappropriate.
<img width="527" alt="image" src="https://github.com/apache/shardingsphere/assets/5668787/6e557de6-967d-4776-b476-80b963ca09e2">
We should add `DistSQLSegment`, which is the same level as `SQLSegment`, and let DistSQL-related segment classes inherit `DistSQLSegment`.
#### Difference
`DistSQLSegment` does not need to provide `getStartIndex()` and `getStopIndex()` methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add DistSQLSegment [shardingsphere]
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #29665: Add DistSQLSegment
URL: https://github.com/apache/shardingsphere/issues/29665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add DistSQLSegment [shardingsphere]
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #29665:
URL: https://github.com/apache/shardingsphere/issues/29665#issuecomment-1879691800
Hi @RaigorJiang I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org