[GitHub] [hudi] leesf commented on a change in pull request #3105: [HUDI-2038] Support rollback inflight compaction instances for CompactionPlanOperator

[GitBox <gi...@apache.org>]

leesf commented on a change in pull request #3105:
URL: https://github.com/apache/hudi/pull/3105#discussion_r656339261



##########
File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/FlinkScheduleCompactionActionExecutor.java
##########
@@ -72,6 +75,17 @@ protected HoodieCompactionPlan scheduleCompaction() {
     boolean compactable = needCompact(config.getInlineCompactTriggerStrategy());
     if (compactable) {
       LOG.info("Generating compaction plan for merge on read table " + config.getBasePath());
+      // roll back the inflight compaction first
+      HoodieTimeline pendingCompactionTimeline = table.getActiveTimeline().filterPendingCompactionTimeline();

Review comment:
       connected offline with @yuzhaojing . Our program will simply ignore it and does not fail will cause the filegroups in compaction plan never get compacted again if not delete inflight instant, we need delete the compaction instant in rollback to make the filegroups to be included in the next compaction plan.  the new change LGTM and will land after CI pass.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org