You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/25 03:31:00 UTC

[jira] [Commented] (AIRFLOW-2846) devel requirement is not sufficient to run tests

    [ https://issues.apache.org/jira/browse/AIRFLOW-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626708#comment-16626708 ] 

ASF GitHub Bot commented on AIRFLOW-2846:
-----------------------------------------

holdenk closed pull request #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py
URL: https://github.com/apache/incubator-airflow/pull/3691
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/setup.py b/setup.py
index aecc218170..8d6f8686eb 100644
--- a/setup.py
+++ b/setup.py
@@ -256,7 +256,8 @@ def write_version(filename=os.path.join(*['airflow',
     'qds-sdk>=1.9.6',
     'rednose',
     'requests_mock',
-    'flake8'
+    'flake8',
+    'tox'
 ]
 
 if not PY3:


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> devel requirement is not sufficient to run tests
> ------------------------------------------------
>
>                 Key: AIRFLOW-2846
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2846
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core
>            Reporter: holdenk
>            Assignee: holdenk
>            Priority: Trivial
>
> The devel requirement doesn't list tox, but `python setup.py test` requires it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)