You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "devCod3r (via GitHub)" <gi...@apache.org> on 2023/07/25 03:16:07 UTC

[PR] [ISSUE #4267] Optimized [GrpcEventMeshCloudEventProtocolResolver] (eventmesh)

devCod3r opened a new pull request, #4279:
URL: https://github.com/apache/eventmesh/pull/4279

   Fixes #4267
   
   ### Motivation
   
   Optimized the class GrpcEventMeshCloudEventProtocolResolver.
   Issue #4267
   
   ### Modifications
   
   Few optimizations has been made to the class GrpcEventMeshCloudEventProtocolResolver.
   
   ### Documentation
   
   - Does this pull request introduce a new feature?
   - Ans: No
   - If a feature is not applicable for documentation, explain why?
   - Ans: Only few optimizations has been made to the mentioned class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


Re: [PR] [ISSUE #4267] Optimized [GrpcEventMeshCloudEventProtocolResolver] (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #4279:
URL: https://github.com/apache/eventmesh/pull/4279#issuecomment-1649187506

   ![image](https://github.com/apache/eventmesh/assets/91315508/fd40adab-ff1b-4daa-931d-382455fa882e)
   please check checkstyle.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4267] Optimized [GrpcEventMeshCloudEventProtocolResolver] (eventmesh)

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4279:
URL: https://github.com/apache/eventmesh/pull/4279#issuecomment-1649397633

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4279?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#4279](https://app.codecov.io/gh/apache/eventmesh/pull/4279?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c51a25a) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/984eacc82629aa78c41e295b65c0f97d4211700b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (984eacc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head c51a25a differs from pull request most recent head 11c5639. Consider uploading reports for the commit 11c5639 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4279      +/-   ##
   ============================================
   - Coverage     16.87%   16.86%   -0.01%     
     Complexity     1426     1426              
   ============================================
     Files           593      593              
     Lines         26068    26064       -4     
     Branches       2396     2382      -14     
   ============================================
   - Hits           4398     4395       -3     
     Misses        21229    21229              
   + Partials        441      440       -1     
   ```
   
   
   [see 7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4279/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4267] Optimized [GrpcEventMeshCloudEventProtocolResolver] (eventmesh)

Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm merged PR #4279:
URL: https://github.com/apache/eventmesh/pull/4279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org