You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2007/08/09 13:16:41 UTC
DO NOT REPLY [Bug 43070] New: - [PATCH] Postscript extension : comment before and after page
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43070>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43070
Summary: [PATCH] Postscript extension : comment before and after
page
Product: Fop
Version: 1.0dev
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: ps
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: dev@cumiskey.com
see http://wiki.apache.org/xmlgraphics-fop/ExtensionsForPostScript for full
details of <ps:ps-comment-before/> and <ps:ps-comment-after/>.
The requirement for the comment-before and comment-after is for post-processing
the postscript output. Both these elements may only be declared as child nodes
of fo:declarations and/or fo:simple-page-master.
In a fo:declarations context, ps-comment-before is placed in the postscript
output just before the %%EndComments DSC comment in the header and
ps-comment-after is placed just after the %%Trailer DSC comment in the footer of
the output.
In a fo:simple-page-master context, ps-comment-before is placed in the
postscript output just after the %%BeginPageSetup DSC comment and a
ps-comment-after just after the %%PageTrailer DSC comment in each page of a
simple page master referring page sequence.
Patch (with dependency on
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144 being applied) to follow.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43070] - [PATCH] Postscript extension : comment before and after page
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43070>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43070
Bug 43070 depends on bug 42144, which changed state.
Bug 42144 Summary: [PATCH] Safely set postscript page device dictionary
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
What |Old Value |New Value
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43070] - [PATCH] Postscript extension : comment before and after page
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43070>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43070
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20625|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-08-10 02:21 -------
Created an attachment (id=20635)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20635&action=view)
patch file
This patch file superceeds the last one. It fixes a bug that I introduced on
PSRenderer.java in the patch file I provided yesterday.
Adrian.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43070] - [PATCH] Postscript extension : comment before and after page
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43070>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43070
------- Additional Comments From dev@cumiskey.com 2007-08-09 09:03 -------
Created an attachment (id=20625)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20625&action=view)
patch file
Again, please note this patch depends upon
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144 being applied first.
Adrian.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43070] - [PATCH] Postscript extension : comment before and after page
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43070>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43070
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |42144
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43070] - [PATCH] Postscript extension : comment before and after page
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43070>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43070
bowditch_chris@hotmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43070] - [PATCH] Postscript extension : comment before and after page
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43070>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43070
bowditch_chris@hotmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From bowditch_chris@hotmail.com 2007-10-05 01:40 -------
Patch Applied with one minor modification. The Abstract class
AbstractPSComment extended PSExtensionAttachment but didn't appear to be
adding any value. PSCommentAfter and PSCommentBefore both extended it but the
Abstract class had nothing more than the constructors. There is no code that
works with the Abstract class either, so it made sense to change
PSCommentAfter & PSCommentBefore to extend PSExtensionAttachment directly.
I then tested the patch using my local PS Printer (and Text Editor) and it
works great. Thanks Adrian!
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.