You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2010/10/23 18:33:54 UTC
svn commit: r1026639 -
/wicket/trunk/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
Author: mgrigorov
Date: Sat Oct 23 16:33:53 2010
New Revision: 1026639
URL: http://svn.apache.org/viewvc?rev=1026639&view=rev
Log:
Findbugs warning: Imposible cast from CopyOnWriteArrayList to ArrayList
It seems since a while FeedbackMessages#messages is CopyOnWriteArrayList and it cannot be trimmed anymore.
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java?rev=1026639&r1=1026638&r2=1026639&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java Sat Oct 23 16:33:53 2010
@@ -49,7 +49,7 @@ public final class FeedbackMessages impl
/**
* Holds a list of {@link org.apache.wicket.feedback.FeedbackMessage}s.
*/
- private List<FeedbackMessage> messages = null;
+ private final List<FeedbackMessage> messages;
/**
* Construct.
@@ -105,7 +105,6 @@ public final class FeedbackMessages impl
messages.removeAll(toDelete);
- trimToSize();
return toDelete.size();
}
@@ -329,17 +328,6 @@ public final class FeedbackMessages impl
}
/**
- * Frees any unnecessary internal storage
- */
- public final void trimToSize()
- {
- if (messages instanceof ArrayList<?>)
- {
- ((ArrayList<?>)messages).trimToSize();
- }
- }
-
- /**
* Adds a new ui message with level WARNING to the current messages.
*
* @param reporter