You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Íñigo Goiri (Jira)" <ji...@apache.org> on 2022/05/25 00:22:00 UTC
[jira] [Commented] (YARN-11137) Improve log message in FederationClientInterceptor
[ https://issues.apache.org/jira/browse/YARN-11137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541759#comment-17541759 ]
Íñigo Goiri commented on YARN-11137:
------------------------------------
Thanks [~slfan1989] for the pull request.
Merged PR 4336 to trunk.
> Improve log message in FederationClientInterceptor
> --------------------------------------------------
>
> Key: YARN-11137
> URL: https://issues.apache.org/jira/browse/YARN-11137
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: YARN-11137.01.patch, YARN-11137.02.patch
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> While reading the relevant yarn-federation-router's code, I found the following issues with log method in FederationClientInterceptor:
> The log methods are inconsistent, some use the splicing method, and some use the placeholder method，as follows:
> org.apache.hadoop.yarn.server.router.clientrmsubmit.FederationClientInterceptor#getNewApplication
> {code:java}
> for (int i = 0; i < numSubmitRetries; ++i) {
> SubClusterId subClusterId = getRandomActiveSubCluster(subClustersActive);
> LOG.debug(
> "getNewApplication try #{} on SubCluster {}", i, subClusterId);
> ApplicationClientProtocol clientRMProxy =
> getClientRMProxyForSubCluster(subClusterId);
> ...
> }{code}
> org.apache.hadoop.yarn.server.router.clientrmsubmit.FederationClientInterceptor#submitApplication
> {code:java}
> for (int i = 0; i < numSubmitRetries; ++i) {
> SubClusterId subClusterId = policyFacade.getHomeSubcluster(
> request.getApplicationSubmissionContext(), blacklist);
> LOG.info("submitApplication appId" + applicationId + " try #" + i
> + " on SubCluster " + subClusterId);
> ...
> } {code}
> I think the first way is better.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org